Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message in service creation #822

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

lechnerc77
Copy link
Member

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

n/a

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 added the bug Something isn't working label May 17, 2024
@lechnerc77 lechnerc77 added this to the 1.4.0 milestone May 17, 2024
@lechnerc77 lechnerc77 self-assigned this May 17, 2024
@lechnerc77 lechnerc77 marked this pull request as ready for review May 17, 2024 12:33
@lechnerc77
Copy link
Member Author

Successful execution of regression test on local build of provider

@lechnerc77
Copy link
Member Author

lechnerc77 commented May 17, 2024

  • Fixture drift is okay as new test case was recorded and existing have been re-recorded to ensure recorded request structure
  • Inclusive language warning is okay as statements come from upstream system that are not managed by us

@lechnerc77 lechnerc77 enabled auto-merge (squash) May 17, 2024 12:35
@lechnerc77 lechnerc77 changed the title fix: improve error message service creation fix: improve error message in service creation May 17, 2024
@vipinvkmenon
Copy link
Member

Looks Good

@lechnerc77 lechnerc77 merged commit 3acfd27 into main May 22, 2024
21 of 23 checks passed
@lechnerc77 lechnerc77 deleted the fix/issue-821 branch May 22, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error Handling during new HANA cloud instance creation
2 participants