New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI5Aggregation.type may be too wide #261

Open

bd82 opened this issue Jul 28, 2020 · 0 comments

Labels

Member

bd82 commented Jul 28, 2020 •

edited

It is currently defined using the general "UI5Type" type union.

ui5-language-assistant/packages/semantic-model-types/api.d.ts

Lines 106 to 111 in f109686

    
           export interface UI5Aggregation extends BaseUI5Node { 
        
             kind: "UI5Aggregation"; 
        
             type: UI5Type | undefined; 
        
             cardinality: UI5Cardinality; 
        
             altTypes: UI5Type[]; 
        
           }

Relevant Discussion:

feat: type aggregation validation #164 (review)

@codeworrior said:

The “type“ property should be restricted to UI5Class | UI5Interface, that’s what the runtime expects
The “altTypes” array is not really validated / restricted in the runtime implementation, but it was originally intended to be limited to primitive types and maybe enums (as they are a kind of primitive)

bd82 added the Tech Debt label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment