Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form]: Read order in forms is not correct and column layout does not work for groups. #5704

Open
1 task done
allen138 opened this issue Apr 11, 2024 · 2 comments
Open
1 task done
Labels
bug Something isn't working SAP SF

Comments

@allen138
Copy link

allen138 commented Apr 11, 2024

Describe the bug

Hi team,

A couple issues:

  1. It was brought to my attention that the read order of the forms is not correct. According to our designers, the read order should be top to bottom then followed by left to right. However, with the current implementation and the read order is left to right, then top to bottom.
  2. When you have two groups and define multiple columns span for your breakpoints, the groups will not break into multiple columns.

Please refer to: https://experience.sap.com/fiori-design-web/form/#top

Isolated Example

Issue 1: https://stackblitz.com/edit/github-pzlhay?file=src%2FApp.tsx
Issue 2: https://stackblitz.com/edit/github-rmcazv?file=src%2FApp.tsx

Reproduction steps

  1. Please see the isolated example, as well as the sapui5 demo links in the 'Expected Behavior' field below.

Expected Behaviour

For issue 1, here is an example of the expected behavior from ui5 classic framework. SimpleForm. https://ui5.sap.com/#/entity/sap.ui.layout.form.SimpleForm/sample/sap.ui.layout.sample.SimpleForm_Column_oneGroup234

For issue 2, here is an example of the expected behavior from ui5 classic framework. SimpleForm.
https://ui5.sap.com/#/entity/sap.ui.layout.form.SimpleForm/sample/sap.ui.layout.sample.SimpleForm_Column_twoGroups234

Screenshots or Videos

Issue 1:
image
image
Issue 2:
image

image

UI5 Web Components for React Version

main

UI5 Web Components Version

main

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SF

Declaration

  • I’m not disclosing any internal or sensitive information.
@allen138 allen138 added the bug Something isn't working label Apr 11, 2024
MarcusNotheis added a commit that referenced this issue Apr 16, 2024
)

When a `Form` contains only `FormItems` and no `FormGroups`, the reading
and tab order of the form items should be first top to bottom, then
start to end.

Part of #5704
MarcusNotheis added a commit that referenced this issue Apr 16, 2024
)

When a `Form` contains only `FormItems` and no `FormGroups`, the reading
and tab order of the form items should be first top to bottom, then
start to end.

Part of #5704
@MarcusNotheis
Copy link
Contributor

Hi @allen138,
Issue 1 should be fixed in v1.27.1.

@i832513
Copy link

i832513 commented May 10, 2024

@MarcusNotheis ,
We noticed that the latest code for Forms works fine when there are zero groups. But whenever we add 1 group the read ordering fix you provided for ungrouped fields is breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SAP SF
Projects
Status: 2024-Q2
Development

No branches or pull requests

3 participants