Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add "add-polygon" icon to replace existing "add-polygone" #6547

Closed
ilhan007 opened this issue Feb 20, 2023 · 0 comments · Fixed by #6564
Closed

[Enhancement] add "add-polygon" icon to replace existing "add-polygone" #6547

ilhan007 opened this issue Feb 20, 2023 · 0 comments · Fixed by #6564
Assignees
Labels
enhancement New feature or request TOPIC Core
Milestone

Comments

@ilhan007
Copy link
Member

ilhan007 commented Feb 20, 2023

Feature Request

The add-polygone icon name has typo in it - it should have been add-polygon. This is already reported to the SAP Design team. Meanwhile let's create an icon with the correct name add-polygon (with the same path as add-polygone) and keep the old one for compatibility.
The add-polygone is already listed in the 2.0 braking change list and will be removed in future.

Expected Behavior

  • Add new icon add-polygon (a copy of add-polygone ) to the SAP Business Suite Icon collection.
  • Replace the usage of add-polygone in the project with add-polygon

Additional info

This is already reflected in the woff-to-svg tool - the SAP BS Icons charcode list is updated and add-polygon is included and new note is added to README.md to describe this special case, that should be taken care when updating the SAP BS Icons charcode list.

Context

  • UI5 Web Components version: {...}
  • OS/Platform: {...}
  • Browser: {...}
  • Affected component: {...}
@ilhan007 ilhan007 added this to New in Planning - Topic Core via automation Feb 20, 2023
@ilhan007 ilhan007 moved this from New to Planned in Planning - Topic Core Feb 20, 2023
@ilhan007 ilhan007 added the enhancement New feature or request label Feb 20, 2023
@ilhan007 ilhan007 changed the title [Enhancement] add "add-polygon" to replace existing "add-polygone" [Enhancement] add "add-polygon" icon to replace existing "add-polygone" Feb 20, 2023
@ilhan007 ilhan007 added this to the 1.11.0 milestone Feb 20, 2023
@ilhan007 ilhan007 self-assigned this Feb 22, 2023
@ilhan007 ilhan007 moved this from Planned to In Progress in Planning - Topic Core Feb 22, 2023
ilhan007 added a commit that referenced this issue Feb 23, 2023
Existing "add-polygone" icon has typo, reported to the SAP Design team. While this is centrally fixed, we create a copy of it, but with corrected name - "add-polygon". The old icon is still shipped, so the change is compatible. In addition, all usages of "add-polygone" are replaced with "add-polygon".
Still, in our docs we refer to the Icon Explorer where one can see only the old name, and probably won't ever see the fixed name. However, as we don't have a better alternative of the icon explorer, we will leave this as it is and wait for central fix.

Fixes: #6547
Planning - Topic Core automation moved this from In Progress to Completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TOPIC Core
Projects
Development

Successfully merging a pull request may close this issue.

1 participant