Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-shellbar]: wrong visual appearance of components that implement IButton interface #8759

Open
1 task done
nnaydenow opened this issue Apr 15, 2024 · 0 comments
Open
1 task done
Labels
bug This issue is a bug in the code TOPIC P

Comments

@nnaydenow
Copy link
Contributor

Bug Description

By documentation startButton slot and newly assistant (#8691) slot accept components that implement IButton interface, which means I can use ui5-button and ui5-toggle-button inside these slot. So when I have following html the buttons aren't aligned with the specification and looks different:

<ui5-shellbar>
	<ui5-button slot="startButton">ui5-button</ui5-button>
	<ui5-toggle-button slot="startButton">ui5-toggle-button</ui5-toggle-button>
	<ui5-button slot="assistant">ui5-button</ui5-button>
	<ui5-toggle-button slot="assistant">ui5-toggle-button</ui5-toggle-button>
</ui5-shellbar>

sap_horizon_dark:
localhost_8080_packages_fiori_test_pages_ShellBar html_sap-ui-theme=sap_horizon_dark
sap_horizon:
localhost_8080_packages_fiori_test_pages_ShellBar html
sap_fiori_3:
localhost_8080_packages_fiori_test_pages_ShellBar html_sap-ui-theme=sap_fiori_3

Affected Component

ui5-shellbar

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@nnaydenow nnaydenow added bug This issue is a bug in the code TOPIC P labels Apr 15, 2024
@nnaydenow nnaydenow added this to Issues in Maintenance - Topic P via automation Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC P
Projects
Development

No branches or pull requests

1 participant