Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][A11y][ui5-textarea]: growingMaxLines does not work when valueState is Error #8767

Open
1 task done
i323808 opened this issue Apr 16, 2024 · 1 comment · May be fixed by #8883
Open
1 task done

[SF][A11y][ui5-textarea]: growingMaxLines does not work when valueState is Error #8767

i323808 opened this issue Apr 16, 2024 · 1 comment · May be fixed by #8883
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RL

Comments

@i323808
Copy link

i323808 commented Apr 16, 2024

Bug Description

growingMaxLines dose not work and only one line text is visible when set ui5-textarea properties as below:
rows = 1
valueState = Error
growing = true
growingMaxLines > 1

Affected Component

ui5-textarea

Expected Behaviour

The maximum number of lines should align with the growingMaxLines property.

Isolated Example

No response

Steps to Reproduce

  1. navigate to https://sap.github.io/ui5-webcomponents/playground/?path=/docs/main-text-area--text-area-overview
  2. set rows = 1, valueState = Error, growing = true, growingMaxLines > 1
  3. type text in text area component
  4. only one line text is visible when the number of lines is greater than growingMaxLines

Log Output, Stack Trace or Screenshots

ui5_textarea_growing

No response

Priority

None

UI5 Web Components Version

1.24.0

Browser

Chrome, Edge, Firefox, Safari

Operating System

macOS Sonoma 14.3.1

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@i323808 i323808 added the bug This issue is a bug in the code label Apr 16, 2024
@dimovpetar dimovpetar self-assigned this Apr 16, 2024
@dimovpetar
Copy link
Contributor

Hello @ui5-webcomponents-topic-rl,

Seems value state play role here.
I have tested with growingMaxLines=5.
image
Same properties, but with valueState=Success:
image

Best regards,
Petar

@dimovpetar dimovpetar removed their assignment Apr 16, 2024
@dimovpetar dimovpetar added this to New Issues in Maintenance - Topic RL via automation Apr 16, 2024
@MapTo0 MapTo0 self-assigned this Apr 30, 2024
@MapTo0 MapTo0 moved this from New Issues to In progress in Maintenance - Topic RL Apr 30, 2024
MapTo0 added a commit that referenced this issue Apr 30, 2024
@MapTo0 MapTo0 linked a pull request Apr 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RL
Projects
Maintenance - Topic RL
  
In progress
Development

Successfully merging a pull request may close this issue.

3 participants