Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-color-palette-popover]: ColorPicker does not take the last selected color from palette #8772

Open
1 task done
henriquemattos opened this issue Apr 16, 2024 · 6 comments

Comments

@henriquemattos
Copy link
Contributor

Bug Description

Hi, team.

If I select a color in the palette (from default colors or from recent colors) and then I choose to open More Colors..., the ColorPicker has the last used color of the Picker, not from the Palette. If no color has been selected in the Picker, then white is predefined.

Affected Component

No response

Expected Behaviour

Selecting colors in the palette would reflect in the picker when choosing "More Colors..."

Isolated Example

No response

Steps to Reproduce

  1. Add ui5-color-palette-popover with showRecentColors, showMoreColors and showDefaultColor;
  2. Define some IColorPaletteItem in the default slot;
  3. Select a color from the palette;
  4. Choose More Colors... to open the ColorPicker;
  5. Check that white is predefined, or the last picked color is used, but not the last palette color selected.

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.20

Browser

Chrome, Edge, Safari

Operating System

No response

Additional Context

No response

Organization

SAP Event Ticketing

Declaration

  • I’m not disclosing any internal or sensitive information.
@henriquemattos henriquemattos added the bug This issue is a bug in the code label Apr 16, 2024
@dimovpetar dimovpetar self-assigned this Apr 16, 2024
@dimovpetar
Copy link
Contributor

Hello @henriquemattos ,

So you would expect that the "More Colors" picker shows the last selected color in the color palette?
https://stackblitz.com/edit/js-ibapyk?file=index.html

Best regards,
Petar

@henriquemattos
Copy link
Contributor Author

Hi, @dimovpetar . I would expect the Color Picker to show the last used color (blue, shown in the color palette in background):

Screenshot 2024-04-17 at 11 50 36

@dimovpetar
Copy link
Contributor

Hello @ui5-webcomponents-topic-b,

Please evaluate this feature request.

Best regards,
Petar

@dimovpetar dimovpetar added feature request TOPIC B and removed bug This issue is a bug in the code author action labels Apr 17, 2024
@dimovpetar dimovpetar added this to New Issues in Maintenance - Topic B via automation Apr 17, 2024
@dimovpetar dimovpetar removed their assignment Apr 17, 2024
@DMihaylova DMihaylova added this to New in Planning - Topic B via automation Apr 18, 2024
@DMihaylova DMihaylova removed this from New Issues in Maintenance - Topic B Apr 18, 2024
@DMihaylova
Copy link

Hi @henriquemattos,

Could you please share more about your use case - why would you need the Color Picker to show the last chosen color from the Color Palette?

@henriquemattos
Copy link
Contributor Author

Hi. Sure, here's my 2 cents:

Short answer is "because the ColorPicker in this case is an extension of the ColorPalette and as a user I would expect the data to be synchronized".

But let's say I choose blue from the palette and realize that with my background and other colors, the contrast is not enough, so I want to adjust RGBA manually for this color. If I don't have the RGBA/HEX from the palette, and the picker open with white, I would have to start from blank, in this case, literally.

Hope that helps.
Cheers,
Henrique

@tsanislavgatev tsanislavgatev self-assigned this Apr 18, 2024
@DMihaylova
Copy link

Thank you @henriquemattos!

The request is now internally logged as FIORITECHE1-8168, and we'll promptly notify you once it's been addressed.

Regards,
Diana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants