Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF][MultiInput]: Backspace does not work when the property set with type="Number" or "Email" #8712

Closed
1 task done
AuroArea opened this issue Apr 10, 2024 · 3 comments · Fixed by #8897
Closed
1 task done

[SF][MultiInput]: Backspace does not work when the property set with type="Number" or "Email" #8712

AuroArea opened this issue Apr 10, 2024 · 3 comments · Fixed by #8897
Assignees
@ndeshev
Labels
bug This issue is a bug in the code Low Prio SAP SF TOPIC RL
Projects
Maintenance - Topic RL

Comments

@AuroArea
Copy link

Describe the bug

The MultiInput component for UI5 React, does not work for Backspace key, when the property type=Number or type=Email is used.

Isolated Example

No response

Reproduction steps

  1. Go to documentation page - https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-multiinput--docs
  2. In the example section, select the input box and try pressing Backspace button, we can see that the tokens are focussed, so that they can be removed.
  3. Now change the dropdown value of the property "type" from Text to "Number" and repeat the above step for backspace, nothing happens.
  4. Tokens are not selected/focussed to take any action

Expected Behaviour

Backspace behaviour should work same for all the "type" properties like it works for type="Text".

Screenshots or Videos

No response

UI5 Web Components for React Version

1.27.0

UI5 Web Components Version

Latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SAP Successfactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@AuroArea AuroArea added the bug This issue is a bug in the code label Apr 10, 2024
@Lukas742
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Apr 10, 2024
@niyap
Copy link
Contributor

niyap commented Apr 10, 2024

Hello @SAP/ui5-webcomponents-topic-rl,

Could you please take a look of that findings?
If we have MultiInput with type="Number" or "Email" (with the other types it works as expected), the keyboard navigation does not work as expected.
Please, check the sample: https://sap.github.io/ui5-webcomponents/components/MultiInput (Add/Remove Tokens). Add some tokens and change the type property to Number or Email. Try to delete the tokens via Backspace -> nothing happens.
Thank you in advance!

Kind Regards,
Niya

@niyap niyap self-assigned this Apr 10, 2024
@niyap niyap added this to New Issues in Maintenance - Topic RL via automation Apr 10, 2024
@niyap niyap removed their assignment Apr 10, 2024
@ndeshev ndeshev self-assigned this Apr 26, 2024
ndeshev added a commit that referenced this issue Apr 26, 2024
@ndeshev
fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'N…
3a0c2e9 
…umber' and 'Email'

related to #8712
@ndeshev ndeshev mentioned this issue Apr 26, 2024
Merged
@ivoplashkov ivoplashkov moved this from New Issues to In progress in Maintenance - Topic RL Apr 29, 2024
ndeshev added a commit that referenced this issue May 2, 2024
@ndeshev
fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'N…
7b5645d 
…umber' and 'Email' (#8866)

* fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'Number' and 'Email'

related to #8712
ndeshev added a commit that referenced this issue May 2, 2024
@ndeshev
fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'N…
2142b8f 
…umber' and 'Email' (#8866)

* fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'Number' and 'Email'

related to #8712
@ndeshev ndeshev mentioned this issue May 2, 2024
Merged
ndeshev added a commit that referenced this issue May 2, 2024
@ndeshev
fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'N…
2ade382 
…umber' and 'Email' (#8866)

* fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'Number' and 'Email'

related to #8712
kgogov pushed a commit to kgogov/ui5-webcomponents that referenced this issue May 2, 2024
@ndeshev @kgogov
fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'N…
db1396f 
…umber' and 'Email' (SAP#8866)

* fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'Number' and 'Email'

related to SAP#8712
@niyap
Copy link
Contributor

niyap commented May 14, 2024

Hello Colleagues,

The issue is fixed with #8897 so I am closing the incident.

Kind Regards,
Niya

@niyap niyap closed this as completed May 14, 2024
Maintenance - Topic RL automation moved this from In progress to Completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndeshev ndeshev

Labels
bug This issue is a bug in the code Low Prio SAP SF TOPIC RL
Projects
Maintenance - Topic RL
  
Completed
Milestone
No milestone
5 participants
@ndeshev @petyabegovska @AuroArea @Lukas742 @niyap