Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select]: The vertical scrollbar remains static when navigating using the keyboard in the list #8987

Closed
1 task done
thefabfabdew opened this issue May 16, 2024 · 3 comments · Fixed by #9053
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code TOPIC P

Comments

@thefabfabdew
Copy link

Describe the bug

The scrollbar remains inactive when navigating by name the list

Isolated Example

https://codesandbox.io/p/devbox/headless-wave-mjcqtw?layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522clw91wqav00073j6g0fb7j5t2%2522%252C%2522sizes%2522%253A%255B70.67385444743935%252C29.326145552560646%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522clw91wqau00023j6gw2c2fk09%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522clw91wqav00043j6gagk7io8z%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522clw91wqav00063j6gzjgu5n1z%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%252C%2522sizes%2522%253A%255B40.84212085499315%252C59.15787914500685%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522clw91wqau00023j6gw2c2fk09%2522%253A%257B%2522id%2522%253A%2522clw91wqau00023j6gw2c2fk09%2522%252C%2522activeTabId%2522%253A%2522clw92ralc001q3j6gjl54hwpe%2522%252C%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clw91wqau00013j6g48s42yyu%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252FREADME.md%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%252C%257B%2522id%2522%253A%2522clw92q1t8004q3j6gsyx5p5xp%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252Fsrc%252Fassets%252Freact.svg%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%252C%257B%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252F.codesandbox%252Ftasks.json%2522%252C%2522id%2522%253A%2522clw92ralc001q3j6gjl54hwpe%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%255D%257D%252C%2522clw91wqav00063j6gzjgu5n1z%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clw91wqav00053j6gbhgxf0zm%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522TASK_PORT%2522%252C%2522taskId%2522%253A%2522dev%2522%252C%2522port%2522%253A5173%252C%2522path%2522%253A%2522%252F%2522%257D%255D%252C%2522id%2522%253A%2522clw91wqav00063j6gzjgu5n1z%2522%252C%2522activeTabId%2522%253A%2522clw91wqav00053j6gbhgxf0zm%2522%257D%252C%2522clw91wqav00043j6gagk7io8z%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clw91wqav00033j6gpnfby6ey%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522TASK_LOG%2522%252C%2522taskId%2522%253A%2522dev%2522%257D%255D%252C%2522id%2522%253A%2522clw91wqav00043j6gagk7io8z%2522%252C%2522activeTabId%2522%253A%2522clw91wqav00033j6gpnfby6ey%2522%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Atrue%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A15%257D

Reproduction steps

  1. Open the select
  2. Select a name (ex : 0BICS_CUST_DIM_MASTE)
  3. Expand the list : the focus is on the previous selected hierarchy
  4. From the keyboard, type "n", "z", the name starting with this letter appears in the field
    ==> it has no impact on the vertical scrollbar

Expected Behaviour

The vertical scrollbar is synchronized when navigating by name the list

Screenshots or Videos

SelectIssue.mp4

UI5 Web Components for React Version

1.26.2

UI5 Web Components Version

1.23.3

Browser

Chrome, Edge

Operating System

Windows

Additional Context

No response

Relevant log output

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@thefabfabdew thefabfabdew added the bug This issue is a bug in the code label May 16, 2024
@Lukas742
Copy link
Collaborator

Hi @thefabfabdew

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Also please note that we moved to StackBlitz as our preferred web IDE/sandbox as it's not possible anymore to edit codeSandboxes with a free plan.


Hi colleagues,

here you can find a simplified example without our wrapper or React: https://stackblitz.com/edit/js-k5glgr?file=index.js

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react May 16, 2024
@nnaydenow
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-p,

Could you please check the issue?

@plamenivanov91 plamenivanov91 self-assigned this May 17, 2024
plamenivanov91 added a commit that referenced this issue May 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Problem: When we type an item which is outside of the scroll viewport, the item is selected but the popover is not scrolled to it.

Solution: We make sure to scroll to the typed item.

Fixes: #8987
plamenivanov91 added a commit that referenced this issue May 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Problem: When we type an item which is outside of the scroll viewport, the item is selected but the popover is not scrolled to it.

Solution: We make sure to scroll to the typed item.

Fixes: #8987
@thefabfabdew
Copy link
Author

Hi @thefabfabdew

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Also please note that we moved to StackBlitz as our preferred web IDE/sandbox as it's not possible anymore to edit codeSandboxes with a free plan.

Hi colleagues,

here you can find a simplified example without our wrapper or React: https://stackblitz.com/edit/js-k5glgr?file=index.js

Thanks for taking care of this, I notified my team about StackBlitz. Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants