New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade or use multi-version for those pure ESM packages #1221
Comments
Ah, we're missing the import maps. Some of it is setup in #1185 |
Oh also, one thing I'd really like is having a way to automatically test that. Because the unit tests are going through build tools, correct ESM functionalities aren't enforced. This makes it really hard to know for certain the build artifacts are/aren't working. |
Went with the path of least resistance to get a quick fix out. I've downgraded all ESM only dependencies to when they were CJS friendly. If anyone want to look into getting #1227 working, the bulk of the work is done. The one downside is it'll likely increase the install size; if not dramatic, it might be a good option. |
Thanks :) I just encountered this issues |
I just sent patch releases of all packages to npm. Let me know if there's still any issues with CJS compatibility 😄 |
I will try to add some extra GitHub Actions workflows for testing this. |
We need to downgrade or use multi-version #1159 (comment) for those pure ESM packages.
The text was updated successfully, but these errors were encountered: