Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade or use multi-version for those pure ESM packages #1221

Closed
LitoMore opened this issue May 4, 2023 · 6 comments
Closed

Downgrade or use multi-version for those pure ESM packages #1221

LitoMore opened this issue May 4, 2023 · 6 comments
Labels

Comments

@LitoMore
Copy link
Sponsor Collaborator

LitoMore commented May 4, 2023

CleanShot 2023-05-05 at 01 53 30@2x

We need to downgrade or use multi-version #1159 (comment) for those pure ESM packages.

@LitoMore LitoMore added the bug label May 4, 2023
@SBoudrias
Copy link
Owner

Ah, we're missing the import maps. Some of it is setup in #1185

@SBoudrias
Copy link
Owner

Oh also, one thing I'd really like is having a way to automatically test that. Because the unit tests are going through build tools, correct ESM functionalities aren't enforced.

This makes it really hard to know for certain the build artifacts are/aren't working.

@SBoudrias
Copy link
Owner

SBoudrias commented May 6, 2023

Went with the path of least resistance to get a quick fix out. I've downgraded all ESM only dependencies to when they were CJS friendly.

If anyone want to look into getting #1227 working, the bulk of the work is done. The one downside is it'll likely increase the install size; if not dramatic, it might be a good option.

@saehun
Copy link

saehun commented May 6, 2023

Thanks :) I just encountered this issues

@SBoudrias
Copy link
Owner

I just sent patch releases of all packages to npm. Let me know if there's still any issues with CJS compatibility 😄

@LitoMore
Copy link
Sponsor Collaborator Author

LitoMore commented May 7, 2023

Oh also, one thing I'd really like is having a way to automatically test that. Because the unit tests are going through build tools, correct ESM functionalities aren't enforced. (@SBoudrias)

I will try to add some extra GitHub Actions workflows for testing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants