New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to ESM #999
Comments
Hi @mesqueeb! Thank you for notifying us! Here are my concerns about pure ES Module packages:
At last, I agree with pushing our ecosystem forward. We could keep this issue open for a while and let other developers know we plan to do this. Cheers to ESM! |
I don't like the idea of packages forcing it's users to use a specific module system. The community should rather strive to make both systems fully interoperable. |
@axelrindle NodeJS already works with import natively. If you want to use legacy NodeJS versions you can simply use an older version of the package you wanna use. |
I agree that we should strive towards esm also You depend on quite some few packages from @sindresorhus that all been switched to esm-only. so to get new updates it would be great to also switch to esm |
PR welcomed to implement ESM modules. It's been out a while, I think it's time to rip the bandaid. |
Hi @SBoudrias , I made a Pull Request for this feature. Please check it out when you have time :) |
Pinging for ts users. Came here with below error.
Seems no other way than givving up using ts-node. switching back to classic |
I answered this over this other thread - please refrain from sharing misinformation out of frustration... This isn't helpful for anyone. If you want to use |
I have this line added to my ts-config but i continue to get the same |
i fixed it by downgrading to version 8.0.1 |
I don't understand what's going on here but downgrading to 8.0.1 helped me too. I'm trying to use ESM modules with TypeScript and Jest. Version 9.1.0 of Inquirer causes Jest to throw:
Commenting out any code which uses Inquirer and running the test works. |
Since the ESM migration was done, I'll close this ticket. But I've opened this one here #1159 to offer a common.js build output too. Help welcome on this task. |
This worked as well thanks!! |
This works, thanks a lot !! |
I mean, could this make us sacrifice in security or features? Can you guys add an option to use BOTH module systems?? |
Like I posted, this is tracked in #1159. I'd be happy to review a PR and facilitate a release about this if you're ready to help. |
Ok thanks |
libraries should be able to support both without needing downgrade versions - if it can't then that's node.js is fault |
some reading on this:
https://blog.sindresorhus.com/get-ready-for-esm-aa53530b3f77
The text was updated successfully, but these errors were encountered: