Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ticket & user setters #55

Open
soryy708 opened this issue Dec 2, 2018 · 1 comment
Open

Refactor ticket & user setters #55

soryy708 opened this issue Dec 2, 2018 · 1 comment
Assignees
Labels
code quality Refactor. Does not affect functionality

Comments

@soryy708
Copy link
Member

soryy708 commented Dec 2, 2018

A lot of ticket setters have the same structure working on slightly different data.
Having so many nearly identical functions is disadvantageous:

  • Harder to maintain
  • Worse readability

Refactor it so all of these functions call 1 general function that does the work.

@soryy708 soryy708 added the code quality Refactor. Does not affect functionality label Dec 2, 2018
@soryy708
Copy link
Member Author

soryy708 commented Dec 3, 2018

Some user setters too.

@soryy708 soryy708 changed the title Refactor ticket setters Refactor ticket & user setters Dec 3, 2018
@IlanTulepov IlanTulepov self-assigned this Dec 6, 2018
@lidorz51 lidorz51 self-assigned this Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Refactor. Does not affect functionality
Development

No branches or pull requests

3 participants