Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing swproj files: Use first filename if subject has no name #354

Open
annehaley opened this issue Nov 16, 2023 · 0 comments
Open

Parsing swproj files: Use first filename if subject has no name #354

annehaley opened this issue Nov 16, 2023 · 0 comments

Comments

@annehaley
Copy link
Collaborator

Currently, swcc will raise an error trying to create subjects with no name. Some swproj files may not have "name" keys on every subject, or if the key exists, the value may be a blank string. This is intentionally allowed in the swproj format for compatibility with old ShapeWorksView2 XML files that don’t support name. The Studio application uses the first filename available for that subject, and it will parse an appropriate name from that.
SWCC should do the same as Studio and should no longer raise a ValueError for empty subject names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant