-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make user aware that findCharactarPos returns top of the line position #2999
base: 2.6.x
Are you sure you want to change the base?
Conversation
Linking #2988 to this |
include/SFML/Graphics/Text.hpp
Outdated
/// origin are applied). | ||
/// the global coordinates (translation, rotation, scale and | ||
/// origin are applied) at the top of the character's text | ||
/// line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd swap it around:
...position is at the top of the character's line in global coordinates...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "character's text line" descriptive enough? If you hadn't had these discussions over the past few days, would you understand what it means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about adding some information to the SFML-Website repo with like an image that we can use to define:
"top of the line"
"bottom of the line"
"line height"
"glyph bounds"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ascender height is very clear and googlable way of documenting what it's doing. I'm happy with this imho
This doesn't need any testing, just documentation changes. I really do think a lot of this confusion may be avoided if we atleast mention this "top of the line" stuff