Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason element-web's dependencies couldn't have nodejs-16 allowed? #5

Closed
realkinetix opened this issue Oct 17, 2022 · 3 comments
Closed

Comments

@realkinetix
Copy link

I couldn't have a server on mine stuck below nodejs 16 LTS any longer, so I updated element-web's RDEPEND to:

<net-libs/nodejs-18

I haven't done a full emerge -e on element-web or anything, so there could be something else that would break. So far, so good, on this system of mine, though.

Anyhow, thanks of course for providing this repo and the element apps!

@TheJJ
Copy link
Member

TheJJ commented Oct 19, 2022

Hey! The reason is stated in the comment above that requirement:

# maybe nodejs version needs to be limited according to these compatibilities:
# https://github.com/node-gfx/node-canvas-prebuilt/releases
# https://nodejs.org/en/download/releases/

element did depend on this node-canvas-prebuilt thingy, but apparently not any more. I've updated my node to v18 and updated element-web/desktop, and it works :)

so I think we can drop that version limiting, but when testing, i ran into discovering nodejs/node-gyp/issues/2750
let's see how deep we need to dig into this rabbit hole...

thanks for the hint!

@realkinetix
Copy link
Author

Well, I hope that turns out OK. I only went as far as 16 as it's LTS.

@TheJJ
Copy link
Member

TheJJ commented Nov 16, 2022

Turns out it didn't so far - surprise! I've now fixed it so it does work with the latest nodejs version... by patching 3 layers of nested dependency fetching - see 3eb701f. Please check if it works for you, too.

@TheJJ TheJJ closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants