Revamp CMake support #1118
Draft
Revamp CMake support #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think we should wait for this before making SOCI 4.1.0 release or can we leave this change until a later 4.1.x? |
Well, it would probably be nice if 4.1 had this already, but it's more of a nice-to-have. So I guess you don't have to wait for this PR to be done. Unrelated to this PR, I would appreciate if #992 made it into 4.1 though :) |
Krzmbrzl
force-pushed
the
revamp-cmake
branch
from
7815446
to
c8d5da6
Compare
This was referenced Feb 17, 2024
Krzmbrzl
force-pushed
the
revamp-cmake
branch
7 times, most recently
from
0b83bb8
to
e1e4433
Compare
Krzmbrzl
force-pushed
the
revamp-cmake
branch
18 times, most recently
from
e4b2e0d
to
39b9037
Compare
Krzmbrzl
force-pushed
the
revamp-cmake
branch
2 times, most recently
from
5b54fcf
to
6aed4e6
Compare
Using the autolink feature seems to lead to linker errors for the Boost date_time library with older versions of Boost and/or older versions of Visual Studio.
Krzmbrzl
force-pushed
the
revamp-cmake
branch
7 times, most recently
from
60bb010
to
793ad26
Compare
That way no compiler should ever emit a warning about something in the associated header files and thus we don't have to jump through hoops in order to avoid warnings that we can't do anything about.
Krzmbrzl
force-pushed
the
revamp-cmake
branch
6 times, most recently
from
d0d1c57
to
e3996d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1115