Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] add memory cache to @salesforce/pwa-kit-runtime/utils/ssr-config getConfig function #1620

Open
luca-izzo opened this issue Dec 15, 2023 · 0 comments · May be fixed by #1621
Open

[FEATURE] add memory cache to @salesforce/pwa-kit-runtime/utils/ssr-config getConfig function #1620

luca-izzo opened this issue Dec 15, 2023 · 0 comments · May be fixed by #1621

Comments

@luca-izzo
Copy link

Problem description
getConfig function inside @salesforce/pwa-kit-runtime/utils/ssr-config/ takes relatively long time to be executed on SSR and when called thousand of times can have a huge impact on the performances.

Proposed solution
Cache getConfig result in memory.

Impacted systems
Both remote and local environments can benefit from this feature.
luca-izzo pushed a commit to luca-izzo/pwa-kit that referenced this issue Dec 15, 2023
@lizzo-tlg
[FEATURE] add memory cache to @salesforce/pwa-kit-runtime/utils/ssr-c…
1b51d6c 
…onfig getConfig function SalesforceCommerceCloud#1620
luca-izzo pushed a commit to luca-izzo/pwa-kit that referenced this issue Dec 15, 2023
@lizzo-tlg
[FEATURE] add memory cache to @salesforce/pwa-kit-runtime/utils/ssr-c…
fd30113 
…onfig getConfig function SalesforceCommerceCloud#1620
luca-izzo added a commit to luca-izzo/pwa-kit that referenced this issue Dec 15, 2023
@luca-izzo
[FEATURE] add memory cache to @salesforce/pwa-kit-runtime/utils/ssr-c…
a68b0f0 
…onfig getConfig function SalesforceCommerceCloud#1620
@luca-izzo luca-izzo linked a pull request Dec 15, 2023 that will close this issue
Open
luca-izzo added a commit to luca-izzo/pwa-kit that referenced this issue Dec 15, 2023
@luca-izzo
[FEATURE] add memory cache to @salesforce/pwa-kit-runtime/utils/ssr-c…
7f9f593 
…onfig getConfig function SalesforceCommerceCloud#1620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@luca-izzo