Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when creating a Recurring Donation in 3.226 #7189

Open
DougYounger opened this issue Aug 29, 2023 · 9 comments
Open

Error when creating a Recurring Donation in 3.226 #7189

DougYounger opened this issue Aug 29, 2023 · 9 comments

Comments

@DougYounger
Copy link

Sandbox updated to W24 and NPSP 3.226 over weekend (8/26).

We're now getting and error when creating a Recurring Donation: "Cannot read properties of undefined (reading 'success')"

This looks exactly like the issue from Summer 22 W-11181894

Created a new Sandbox with Summer 23 and 3.225 and error is not present.

@UnicefAbhiSharma009
Copy link

Hey @DougYounger
Could you please let us know when this would be sorted, we have the managed package and have dependencies on NPSP latest package (currently it shows 3.226) but since it is not getting upgraded to 3.226 and also this version has bugs, could you please tell when we will be able to resolve this? Our release is getting impacted.

@judisohn
Copy link
Contributor

@UnicefAbhiSharma009 - @DougYounger doesn't work for Salesforce (neither do I anymore).

Your best bet is to open a Salesforce support ticket. Salesforce does not monitor or reply to issues here.

@UnicefAbhiSharma009
Copy link

@judisohn @DougYounger

Thanks for replying. I raised the case to salesforce but it is completely NPSP issue. NPSP Github - latest version points to 3.226 but NPSP installer (https://install.salesforce.org/products/npsp/latest/install) says latest is 3.225, so our managed package during upgrade checks for 3.226, and throws error. NPSP has not made 3.226 available for user domain, may be due to this ongoing issue but this is impacting our planned release.
So now, the problem is :

  1. I cannot install 3.226 in our org manually, since it has bugs.
  2. And in our package upgrades, I cannot set cumulus dependencies to check NPSP (3.225). Since they do not have that feature to install with 1 lower NPSP version. (https://cumulusci.readthedocs.io/en/stable/dev.html#controlling-github-dependency-resolution)

WE ARE STRUCK HERE.

@judisohn
Copy link
Contributor

Why do you think the problem is about bugs? This is standard every release when the latest is pushed to sandboxes ahead of production 6 weeks later. MetaDeploy is updated to release in production.

Why can't you change your package version dependency?

There used to be a way to change the URL in MetaDeploy to target a different release but now I can't remember the syntax.

@UnicefAbhiSharma009
Copy link

So this is cumulus documentation https://cumulusci.readthedocs.io/en/stable/dev.html#controlling-github-dependency-resolution.
It does not give us any option to add any specific version.
project:
dependencies:
- github: https://github.com/SalesforceFoundation/EDA

@judisohn
Copy link
Contributor

Have others confirmed the same error with recurring donations? Did you replicate it in a scratch org or sandbox yourself? As I've said, not having the latest release in installer until production push is normal.

There's no KI created for this as a broad bug. What did support say?

@judisohn
Copy link
Contributor

Support shouldn't say "it's NPSP issue" and point you here. NPSP is a Salesforce product.

@georgeslater
Copy link

@judisohn I think the issue is that NPSP releases such as https://github.com/SalesforceFoundation/NPSP/releases/tag/rel%2F3.225 used to contain the package URL. That meant that if there was any mismatch (our package had a dependency on latest NPSP release, NPSP release had been created but not yet pushed to sandboxes) then the sandbox could be manually upgraded.

Whereas with the latest release (https://github.com/SalesforceFoundation/NPSP/releases/tag/rel%2F3.226) there is no package install link, and as you say we cannot get it from MetaDeploy as 3.226 does not yet exist there.

So we would either need to request Salesforce support for the package link each time, or attempt to run the CumulusCI update_dependencies task which is not easy for non-technical users.

@UnicefAbhiSharma009

@judisohn
Copy link
Contributor

@georgeslater For various reasons, the page stopped including the package ID quite a while ago. Instead, Salesforce used to put the release in MetaDeploy only accessible via the URL until production push, so folks could intentionally upgrade in advance of the push for this exact scenario.

See for example https://install.salesforce.org/products/npsp/3.223/upgrade for version 3.223 - but https://install.salesforce.org/products/npsp/3.226/upgrade does not work as it should for 3.226. Support needs to have the team with access to MetaDeploy update so that URL works and the problem is solved.

@UnicefAbhiSharma009 In the meantime, I haven't tried this and I don't know for sure... but do you think if you set your dependencies based on the namepspace rather that Github repo it would work? https://cumulusci.readthedocs.io/en/stable/dev.html#package-dependencies?

project:
    dependencies:
        - namespace: npsp
          version: 3.225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants