Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rxjs to peerDependencies to allow custom versions usage #125

Open
kctang opened this issue Nov 7, 2018 · 1 comment
Open

Move rxjs to peerDependencies to allow custom versions usage #125

kctang opened this issue Nov 7, 2018 · 1 comment

Comments

@kctang
Copy link

kctang commented Nov 7, 2018

I am getting "TypeError: You provided an invalid object where a stream was expected. You can provide an Observable, Promise, Array, or Iterable." in my application and I traced it to this library's dependency on rxjs.

While my application does not use listr directly, it has webpack-cli as a devDepdencies. And webpack-cli depends on listr.

Hope you can make this change so I don't have to 'workaround' the issue.

Also, as mentioned here, rxjs should be a peerDependencies in library modules.

Cheers!

@gpetrov
Copy link

gpetrov commented Mar 19, 2019

@SamVerschueren please get rid of the rxjs dependency this brings 16MB and 3.5K files to the node_modules - way too much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants