Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dedicated type for BitString #23

Open
Samuel-Tyler opened this issue May 9, 2020 · 0 comments
Open

Create dedicated type for BitString #23

Samuel-Tyler opened this issue May 9, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Samuel-Tyler
Copy link
Owner

Currently BitString uses the generic StringImpl for its implementation. Instead, a specific type for BitString should be created. This should be construct-able from binary data, and also a range of bools (including std::vector). Conversion to std::vector should be provided.

This will allow the BitString to be constructed from an ASN.1 value in the syntax { 1, 0, 1, ... }.

Acceptance

  • Functions in the BitString type are populated
  • Test cases are added to test/ber_types/BitString.cpp
  • BitString is added to test/ber_types/AllTest.cpp
  • BitString is added to benchmarks/ComponentPerformance.cpp
  • BitString is convertable to / from std::vector
@Samuel-Tyler Samuel-Tyler added help wanted Extra attention is needed enhancement New feature or request labels May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant