Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ZIO OTEL metrics to use ConcurrentMetricRegistry #634

Closed
ptrdom opened this issue Mar 8, 2023 · 1 comment · Fixed by #639
Closed

Refactor ZIO OTEL metrics to use ConcurrentMetricRegistry #634

ptrdom opened this issue Mar 8, 2023 · 1 comment · Fixed by #639
Assignees
Milestone

Comments

@ptrdom
Copy link
Member

ptrdom commented Mar 8, 2023

Our current approach to instrumenting ZIO metrics breaks if their mapping functions are used. A better approach would be to interact directly with ConcurrentMetricRegistry. It does provide two approaches - pull based snapshots and push based listeners. Currently push based 'listeners' have at least one issue with them that makes them non-ideal to use - see zio/zio#7897 (comment). We should implement pull based snapshots approach now, maybe consider implementing push based listeners approach in the future and allow users of the Mesmer to toggle which one they want to use.

Should resolve #629 and #423.

@ptrdom ptrdom added this to the 0.8.0 milestone Mar 8, 2023
@ptrdom ptrdom self-assigned this Mar 8, 2023
@ptrdom
Copy link
Member Author

ptrdom commented Mar 8, 2023

Seems like there is no implementation yet for synchronous gauge - open-telemetry/opentelemetry-specification#2318.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant