Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change SA to EU region for ads #593

Merged
merged 3 commits into from May 8, 2024
Merged

fix: change SA to EU region for ads #593

merged 3 commits into from May 8, 2024

Conversation

NishealJ
Copy link
Contributor

@NishealJ NishealJ commented Dec 20, 2023 •
edited by moltar

Closes #592

@moltar
Copy link
Collaborator

moltar commented Dec 20, 2023 •
edited

Thanks, good catch. Could you please update the snapshots?

npm test -- test/marketplaces.test.ts -u

@moltar moltar changed the title Fixes #592: SA is EU region for amazon ads fix: change SA to EU region for ads Dec 20, 2023
@nguyentoanit nguyentoanit merged commit d7ac064 into ScaleLeap:master May 8, 2024
1 of 5 checks passed
@nguyentoanit nguyentoanit mentioned this pull request May 8, 2024
Merged
nguyentoanit added a commit that referenced this pull request May 8, 2024
@nguyentoanit
test: update snapshots (#618)
a4a8799 
This PR is to update the snapshots which I couldn't in #593
github-actions bot pushed a commit that referenced this pull request May 8, 2024
@semantic-release-bot
chore(release): 17.3.1 [skip ci]
7b53b96 
## [17.3.1](v17.3.0...v17.3.1) (2024-05-08)

### Bug Fixes

* change SA to EU region for ads ([#593](#593)) ([d7ac064](d7ac064)), closes [#592](#592)
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

🎉 This PR is included in version 17.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SA is EU region for amazon ads.
3 participants
@NishealJ @moltar @nguyentoanit