Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update]: smplayer's persistent data will be in dedicated subdirectory #13157

Open
3 tasks done
goyalyashpal opened this issue Apr 22, 2024 · 1 comment
Open
3 tasks done
Labels

Comments

@goyalyashpal
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

smplayer

Expected/Current Behaviour

the details of current manifest of smplayer are listed here:

the details of behaviour after update is that, all these persistent configs .ini or .m3u8 files are moved under config/ directory

Steps to Reproduce

> scoop install smplayer

> # https://superuser.com/q/318197/a#1056648
> # See the scattered persistent files in the install dir of smplayer
> dir <scoop-apps-dir>/smplayer/current/ | where {$_.extension -in ".ini", ".m3u8"}

> # See that 'config' subdir is missing
> test-path <scoop-apps-dir>/smplayer/current/config

Possible Solution

change the manifest to reflect that.
the problem is that the existing persistent files will have to be moved in the config/ dir too
other than that, there's not much to it.

for a trial of this fresh behaviour at dev builds, i created this manifest for myself:

{
    "$schema": "https://raw.githubusercontent.com/ScoopInstaller/Scoop/master/schema.json",
    "description": "A video player forked from MPV. It can also play Youtube videos, search and download subtitles, and includes other features like a thumbnail generator and audio and video filters.",
    "homepage": "https://www.smplayer.info/",
    "license": "GPL-2.0-or-later",
    "extract_dir": "smplayer-portable",
    "shortcuts": [
        [
            "smplayer.exe",
            "SMPlayer"
        ]
    ],
    "persist": [
        "screenshots",
        "config"
    ],
    "checkver": {
        "url": "https://api.github.com/repos/smplayer-dev/smplayer/releases",
        "jsonpath": "$[0].assets[*].name",
        "regex": "smplayer-portable-([\\d.]+)-win32-qt(?<qtversion>[\\d.]+)\\.7z"
    },
    "autoupdate": {
        "architecture": {
            "64bit": {
                "url": "https://github.com/smplayer-dev/smplayer/releases/download/v$version/smplayer-portable-$version-x64.7z"
            },
            "32bit": {
                "url": "https://github.com/smplayer-dev/smplayer/releases/download/v$version/smplayer-portable-$version-win32-qt$matchQtversion.7z"
            }
        }
    },
    "version": "23.12.0.10266",
    "architecture": {
        "64bit": {
            "url": "https://github.com/smplayer-dev/smplayer/releases/download/v23.12.0.10266/smplayer-portable-23.12.0.10266-x64.7z",
            "hash": "1c0c88a507e8e7aeb4b432e3c1e4a303f4da753b2fba2121394a7cfcf057b4fa"
        },
        "32bit": {
            "url": "https://github.com/smplayer-dev/smplayer/releases/download/v23.12.0.10266/smplayer-portable-23.12.0.10266-win32-qt5.6.7z",
            "hash": "faa113ea8b2f26088be5f19bc60092a06e348d11388a7c6c0ce7f1543037b7c6"
        }
    }
}

Scoop and Buckets Version

> scoop --version
Current Scoop version:
105e4161 (HEAD -> master, tag: v0.4.0, origin/master, origin/HEAD) chore(release): Bump to version 0.4.0 (#5424)

'main' bucket:
623969617 (HEAD -> master, origin/master, origin/HEAD) vfox@0.4.1: Fix hash (Closes #5735)

'extras' bucket:
a0a043ccb (HEAD -> master, origin/master, origin/HEAD) youtrack: Update to version 2024.1.28928

'nerd-fonts' bucket:
6d01d9ec (HEAD -> master, origin/master, origin/HEAD) SarasaGothic: Update to version 1.0.10

'nonportable' bucket:
2fd31611 (HEAD -> master, origin/master, origin/HEAD) autohotkey-np: Update to version 2.0.13

'java' bucket:
04ec327c (HEAD -> master, origin/master, origin/HEAD) temurin22-jre: Update to version 22.0.1-8

'dorado' bucket:
23176ec1 (HEAD -> master, origin/master, origin/HEAD) swift-nightly: Update to version 20240421.3

'svah' bucket:
fatal: not a git repository (or any of the parent directories): .git

Scoop Config

> scoop config


root_path    : D:\UserFiles\scoop
global_path  : D:\ProgramFiles\scoop_global
last_update  : 2024-04-22T20:21:36.8486836+05:30
alias        : @{cat-dum=scoop-cat-dum}
debug        : True
scoop_branch : master
scoop_repo   : https://github.com/ScoopInstaller/Scoop

PowerShell Version

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.4170
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.4170
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

  • smplayer
@goyalyashpal
Copy link
Contributor Author

it is released now

https://www.smplayer.info/en/changes

> scoop status
WARN  Scoop bucket(s) out of date. Run 'scoop update' to get the latest changes.

Name                       Installed Version    Latest Version         Missing
                                                                       Dependen
                                                                       cies
----                       -----------------    --------------         --------
smplayer                   23.12.0.0            24.5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant