vokoscreenng-np@4.1.0: installation reports "$dir\vcredist_2010_x64.exe" does not exist

[kkimurak]

Bug Report

Package Name: [name of package which has bug(s)]

vokoscreenng-np@4.1.0

Current Behaviour

Installing vokoscreenng-np reports following error (but it was installed successfully. App runs normally as well)

Installing 'vokoscreenng-np' (4.1.0) [64bit] from nonportable bucket
vokoscreenNG-4.1.0-win64.exe (113.0 MB) [=====================================================================] 100%
Checking hash of vokoscreenNG-4.1.0-win64.exe ... ok.
Linking C:\scoop\apps\vokoscreenng-np\current => C:\software\scoop\apps\vokoscreenng-np\4.1.0
Running post_install script...
Remove-Item:
Line |
   3 |  Remove-Item "$dir\setup.exe", "$dir\vcredist_2010_x64.exe"
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path 'C:\scoop\apps\vokoscreenng-np\current\vcredist_2010_x64.exe' because it does not exist.
'vokoscreenng-np' (4.1.0) was installed successfully!

(Replaced error message after setting UI language to en-US)

Expected Behaviour

Reports no error

Additional context/output

VokoscreenNG for windows version 4.1.0 no longer contains vcredist_2010 installer. It have been replaced by vcruntime140.dll and vcruntime140_1.dll. See vkohaupt/vokoscreenNG#310
Current post_install script will try to remove vcredist installer and reports such error.

    "post_install": [
        "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
        "Start-Process \"$dir\\setup.exe\" -Wait -Verb 'RunAs' -WindowStyle 'Hidden' -ArgumentList @('in', '-c', '--am', '--al', '-t', \"$dir\")",
        "Remove-Item \"$dir\\setup.exe\", \"$dir\\vcredist_2010_x64.exe\""
    ],

I originally posted #297 but it have been closed automatically because I set a wrong title so that the bot recognized that the problematicVersion is 4.1.0 and does not match to the latest version 4.1.0

Possible Solution

Remove vcredist from post_install removal target.
I'm ready to submit PR if it is OK.

    "post_install": [
        "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
        "Start-Process \"$dir\\setup.exe\" -Wait -Verb 'RunAs' -WindowStyle 'Hidden' -ArgumentList @('in', '-c', '--am', '--al', '-t', \"$dir\")",
        "Remove-Item \"$dir\\setup.exe\""
    ],

System details

Windows version: [e.g. 7, 8, 10]

11

OS architecture: [e.g. 32bit, 64bit]

64bit

PowerShell version: [output of "$($PSVersionTable.PSVersion)"]

Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      22621  2506

Additional software: [(optional) e.g. ConEmu, Git]

Scoop Configuration

{
  "last_update": "2024-04-08T00:11:12.1991676+09:00",
  "scoop_repo": "https://github.com/lukesampson/scoop",
  "scoop_branch": "master"
}