Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Shim creation fails following #5836 #5863

Closed
svraka opened this issue Apr 3, 2024 · 2 comments · Fixed by #5424
Closed

[Bug] Shim creation fails following #5836 #5863

svraka opened this issue Apr 3, 2024 · 2 comments · Fixed by #5424
Labels

Comments

@svraka
Copy link
Contributor

svraka commented Apr 3, 2024

Bug Report

Current Behavior

On the develop branch shim creation leads to an error.

PS > scoop shim add quarto2 C:\scoop\apps\quarto\current\bin\quarto.exe
Adding local shim quarto2...
Add-Path: C:\scoop\apps\scoop\current\lib\core.ps1:831
Line |
 831 |      Add-Path -Path $abs_shimdir -Global:$global
     |      ~~~~~~~~
     | The term 'Add-Path' is not recognized as a name of a cmdlet, function, script file, or executable
     | program. Check the spelling of the name, or if a path was included, verify that the path is correct
     | and try again.

Expected Behavior

Shims can be created.

Additional context/output

The bug was introduced in #5836, the commit before it was merged (77b66cc) works as expected.

Possible Solution

Importing system.ps1 in scoop-shim.ps1. WIP in https://github.com/svraka/Scoop/tree/follow-up-5836. Happy to open a PR for a single change but since tests didn't catch this omission, there might be some other bugs in different codepaths.

System details

Windows version: 10 22H2

OS architecture: 64bit

PowerShell version: 7.4.1

Additional software: None

Scoop Configuration

{
  "alias": {},
  "last_update": "2024-04-03T13:08:56.668487+02:00",
  "scoop_branch": "develop",
  "scoop_repo": "https://github.com/ScoopInstaller/Scoop"
}
@svraka svraka added the bug label Apr 3, 2024
@niheaven
Copy link
Member

niheaven commented Apr 3, 2024

Please make the PR

@svraka
Copy link
Contributor Author

svraka commented Apr 4, 2024

Please make the PR

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants