rename_to() error

[Mohan-sharma-Venkatesh]

Description

1. rename_to() error
   The rename_to() function of struct
   Struct sea_orm_migration::manager::SchemaManager
   produces an error. The rename_to() is a function used to rename the Type.
   But produces an error because it is not able to generate the SQL statement with double quotes
   --> It produces the SQL statement with single quotes

Steps to Reproduce

0. Seo orm version and information in cargo.toml

sea-orm = { version = "0.12.0", features = [ "with-chrono", "sqlx-postgres", "runtime-async-std-native-tls", "macros" ] }

Postgres DB version = 6.19

1. Create a migrations file with the name alter_type.rs using the terminal command

sea-orm-cli migrate generate "alter_type"

2. paste the code below

use crate::extension::postgres::Type;
use sea_orm_migration::prelude::*;

#[derive(DeriveMigrationName)]
pub struct Migration;

#[async_trait::async_trait]
impl MigrationTrait for Migration {
    async fn up(&self, manager: &SchemaManager) -> Result<(), DbErr> {
        let create_type = Type::create()
            .as_enum(Number::Number)
            .values([Number::One, Number::Two])
            .to_owned();
        dbg!(create_type.to_string(PostgresQueryBuilder));
        manager.create_type(create_type).await
    }

    async fn down(&self, manager: &SchemaManager) -> Result<(), DbErr> {
        let alter_type_name = Type::alter()
            .name(Number::Number)
            .rename_to(RenameType::Phonenumber); //This will create an error because of rename_to()
        dbg!(alter_type_name.to_string(PostgresQueryBuilder));
        manager.alter_type(alter_type_name).await
        // This below lines are raw query will work perfectly and rename type
        // let raw_rename_type = r#"
        // ALTER TYPE number RENAME TO phonenumber;
        // "#;
        // manager
        //     .get_connection()
        //     .execute_unprepared(raw_rename_type)
        //     .await?;
        // Ok(())
    }
}

#[derive(DeriveIden)]
enum Number {
    Number,
    One,
    Two,
}

#[derive(DeriveIden)]
enum RenameType {
    Phonenumber,
}

3. Then run a fresh migration command in the terminal

DATABASE_URL="url" sea-orm-cli migrate fresh 

4. After fresh is successfully migrate Down using terminal

DATABASE_URL="url" sea-orm-cli migrate down

5. This will create an error
   

6. If you run only the raw query then the migration will run and rename the Type without any error

7. This states that there is an error near 'phonenumber'

Expected Behavior

This rename_to() function must generate SQL command

ALTER TYPE "number" RENAME TO "phonenumber"

Actual Behavior

This remate_to() function actually generates

ALTER TYPE "number" RENAME TO 'phonenumber'

Difference is

'phonenumber' --> generated [This is produce the error]
"phonenumber" --> expected [This will work perfectly]

Must have generate " " instead of ' '

Reproduces How Often

This happens whenever you use the rename_to() function

Workarounds

Must have generated " " instead of ' '

Reproducible Example

Versions

[tyt2y3]

Can you verify this on newer version of Postgres? I want to double check on it. It seems like a bug that has always been there.

[zezic]

I faced the same issue using PostgreSQL 16. Can we have a fix?