Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update clap to last version: clap = { version = "3.1.8", #664

Closed
igotfr opened this issue Apr 5, 2022 · 6 comments · Fixed by #706
Closed

update clap to last version: clap = { version = "3.1.8", #664

igotfr opened this issue Apr 5, 2022 · 6 comments · Fixed by #706

Comments

@igotfr
Copy link

igotfr commented Apr 5, 2022

Summary

Motivation

Additional Information

[dependencies]
clap = { version = "3.1.8", features = ["derive"] }

@igotfr
Copy link
Author

igotfr commented Apr 5, 2022

cli.rs

lines 3, 96

the migration guide and list of breaking changes lists:

3.1.0 - 2022-02-16

Deprecations

clap::Command is now preferred over clap::App (#3089 in #3472)


lines 4, 8, 83, 86

use of deprecated struct clap::SubCommand: Replaced with Command::new unless you intended the Subcommand trait rustc(deprecated)


lines 6, 98

clap-rs/clap#3611
the migration guide and list of breaking changes lists:

3.0.0 - 2021-12-31

BREAKING CHANGES

From clap 2

Easier to catch changes:
Removed VersionlessSubcommands, making it the default (see clap-rs/clap#2812)


lines 11, 20, 31, 39, 45, 54, 61, 68, 77, 102

use of deprecated associated function clap::Arg::<'help>::with_name: Replaced with Arg::new
#[warn(deprecated)] on by default rustc(deprecated)


lines 13, 22, 33, 47, 79, 104

the migration guide and list of breaking changes lists:

3.0.0 - 2021-12-31

BREAKING CHANGES

From clap 2

Easier to catch changes:
Arg::short and Arg::value_delimiter now take a char instead of a &str


lines 17, 28

no method named env found for struct Arg in the current scope, method not found in Arg<'_>rustcE0599
the migration guide and list of breaking changes lists:

3.0.0 - 2021-12-31

BREAKING CHANGES

From clap 2

Subtle changes (i.e. compiler won't catch):
Arg::env, Arg::env_os, Arg::last, Arg::require_equals, Arg::allow_hyphen_values, Arg::hide_possible_values, Arg::hide_default_value, Arg::hide_env_values, Arg::case_insensitive and Arg::multiple_values no longer imply ArgSettings::TakesValue (clap-rs/clap#2233)


lines 75, 109

clap-rs/clap#3618
the migration guide and list of breaking changes lists:

3.1.0 - 2022-02-16

Deprecations

(validation) clap::Command::subcommand_required(true).arg_required_else_help(true) is now preferred over clap::AppSettings::SubcommandRequiredElseHelp (clap-rs/clap#3280

commands.rs

lines 7, 174

this struct takes 0 lifetime arguments but 1 lifetime argument was supplied
expected 0 lifetime arguments rustcE0107
arg_matches.rs(70, 12): struct defined here, with 0 lifetime parameters


lines 9, 177, 210

the migration guide and list of breaking changes lists:

3.0.0 - 2021-12-31

BREAKING CHANGES

From clap 2

Easier to catch changes:
Changed ArgMatches::subcommand to now return Option<(&str, &ArgMatches)>


lines 269, 286, 303, 318, 333, 348

the migration guide and list of breaking changes lists:

3.1.0 - 2022-02-16

Deprecations

(builder) clap::AppSettings are nearly all deprecated and replaced with builder methods and getters (#2717)
use of deprecated variant clap::AppSettings::NoBinaryName: Replaced with Command::no_binary_name

@ikrivosheev
Copy link
Member

@cindRoberta I am working on this PR. I'll do it soon

@igotfr
Copy link
Author

igotfr commented Apr 9, 2022

@cindRoberta I am working on this PR. I'll do it soon

I'm too, do you want to exchange information? did you open a fork?

@ikrivosheev
Copy link
Member

@cindRoberta Oh, then keep working, I'll take another task)

@billy1624
Copy link
Member

Thanks!! @cindRoberta @ikrivosheev

@smonv
Copy link
Contributor

smonv commented May 10, 2022

@cindRoberta do you still working on this ?

@smonv smonv mentioned this issue May 10, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants