Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SeleniumHQ/selenium
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b1d3319b48304bca40a8a35cdd95cb05d8464497
Choose a base ref
...
head repository: SeleniumHQ/selenium
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5f9cec8963b33a7708619d666a5ce0b2f6542c7d
Choose a head ref

Commits on Feb 20, 2024

  1. [build] Fixing API docs update

    diemol committed Feb 20, 2024
    Copy the full SHA
    c6bd096 View commit details
  2. Copy the full SHA
    989b0ca View commit details
  3. Copy the full SHA
    f99f01a View commit details

Commits on Feb 21, 2024

  1. Copy the full SHA
    78029c4 View commit details

Commits on Feb 22, 2024

  1. Bump cryptography from 41.0.4 to 42.0.4 in /py (#13615)

    Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.4 to 42.0.4.
    - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
    - [Commits](pyca/cryptography@41.0.4...42.0.4)
    
    ---
    updated-dependencies:
    - dependency-name: cryptography
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Feb 22, 2024
    Copy the full SHA
    93c7804 View commit details

Commits on Feb 23, 2024

  1. Copy the full SHA
    ddaa4aa View commit details
  2. [dotnet] Notice about breaking changes at compilation level for desir…

    …ed capabilities
    
    Related to #13609
    nvborisenko committed Feb 23, 2024
    Copy the full SHA
    cc93539 View commit details

Commits on Feb 26, 2024

  1. [rb] Run all unit tests in RBE

    p0deje committed Feb 26, 2024
    Copy the full SHA
    2418844 View commit details
  2. Copy the full SHA
    da62a40 View commit details

Commits on Feb 29, 2024

  1. Copy the full SHA
    db51776 View commit details

Commits on Mar 1, 2024

  1. Copy the full SHA
    aefde12 View commit details
  2. Copy the full SHA
    d65e38e View commit details

Commits on Mar 3, 2024

  1. Copy the full SHA
    5bc8952 View commit details

Commits on Mar 4, 2024

  1. Add devcontainer.json to ease local dev environment setup (#13638)

    * Added devcontainer.json
    
    Added devcontainer.json
    
    * Moved file to devcontainer folder
    
    Moved devcontainer.json to devcontainer folder
    
    * Documented Dev Container setup in README
    
    Section 'Using Docker Image' rephrased to include Dev Container setup documentation
    
    * Added back the original section 'Using Docker Image'
    
    Dev Container section separated from Docker Image section
    
    ---------
    
    Co-authored-by: Trig <7973740+Trigtrig@users.noreply.github.com>
    Trigtrig and Trigtrig authored Mar 4, 2024
    1
    Copy the full SHA
    c0711e2 View commit details
  2. Copy the full SHA
    1cfe991 View commit details

Commits on Mar 5, 2024

  1. Copy the full SHA
    b9a95a3 View commit details

Commits on Mar 7, 2024

  1. Copy the full SHA
    832a31e View commit details

Commits on Mar 8, 2024

  1. Copy the full SHA
    ffedae3 View commit details
  2. Fix JS linting errors

    shs96c committed Mar 8, 2024
    Copy the full SHA
    3c05175 View commit details
  3. [ci] automatically close issues marked awaiting answer (#13668)

    [ci] automatically close issues marked awaiting answer if no reply in 14 days
    titusfortner authored Mar 8, 2024
    Copy the full SHA
    8f7c7a4 View commit details

Commits on Mar 9, 2024

  1. Copy the full SHA
    d266777 View commit details

Commits on Mar 10, 2024

  1. Copy the full SHA
    d073e59 View commit details
  2. Remove some printf debugging

    shs96c committed Mar 10, 2024
    Copy the full SHA
    7384157 View commit details

Commits on Mar 11, 2024

  1. Copy the full SHA
    739f5ec View commit details
  2. Copy the full SHA
    ffed982 View commit details
  3. Copy the full SHA
    420f074 View commit details
  4. [rb] Avoid overescaping browser path

    Related to #13632
    p0deje committed Mar 11, 2024
    Copy the full SHA
    a66db94 View commit details
  5. Copy the full SHA
    eae8507 View commit details
  6. [bazel] Update rules_java

    This fixes broken build on Windows failing with:
    
    ERROR: C:/tmp/5rcabgft/external/rules_java_builtin/toolchains/BUILD:283:27: While resolving toolchains for target @@rules_java_builtin//toolchains:remotejdk_21 (c81c515): No matching toolchains found for types @@bazel_tools//tools/jdk:runtime_toolchain_type.
    p0deje committed Mar 11, 2024
    Copy the full SHA
    ad17dd2 View commit details

Commits on Mar 13, 2024

  1. Copy the full SHA
    77521cc View commit details
  2. [js] Fix linting

    pujagani committed Mar 13, 2024
    Copy the full SHA
    9fa8a62 View commit details
  3. Copy the full SHA
    eddd906 View commit details
  4. Copy the full SHA
    83083c6 View commit details

Commits on Mar 14, 2024

  1. Copy the full SHA
    cce0385 View commit details
  2. Copy the full SHA
    b5ded12 View commit details
  3. Copy the full SHA
    2b8fa0c View commit details
  4. Copy the full SHA
    a3811c4 View commit details
  5. Copy the full SHA
    8ab92eb View commit details
  6. Copy the full SHA
    8909a53 View commit details
  7. Copy the full SHA
    fccae20 View commit details

Commits on Mar 15, 2024

  1. Copy the full SHA
    a1a5463 View commit details
  2. [rust] Revert lock files

    bonigarcia committed Mar 15, 2024
    Copy the full SHA
    552a2aa View commit details
  3. [rust] Revert dependencies

    bonigarcia committed Mar 15, 2024
    Copy the full SHA
    12fac08 View commit details
  4. Copy the full SHA
    2f0a93d View commit details
  5. [dotnet] Add dispose on constructor failure to ensure driver closes (#…

    …13673)
    
    * Forced Dispose of driver on chromedriver exception
    
    * Changed try-catch to only envelop StartSession and moved driver Quit command to own function
    
    * Remove extra spaces
    
    * Undo DriverDispose changes and instead call quit
    
    ---------
    
    Co-authored-by: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com>
    MASACR99 and nvborisenko authored Mar 15, 2024
    Copy the full SHA
    4c0ac3d View commit details
  6. [bazel] Update pinned browser

    p0deje committed Mar 15, 2024
    Copy the full SHA
    c77e216 View commit details
  7. Copy the full SHA
    bd540f2 View commit details
  8. [ci] Bump setup-bazel

    p0deje committed Mar 15, 2024
    Copy the full SHA
    4e17575 View commit details
  9. Copy the full SHA
    e9bbb29 View commit details
  10. [rb] Enable Edge tests on RBE

    p0deje committed Mar 15, 2024
    Copy the full SHA
    cb98925 View commit details
Showing 727 changed files with 38,079 additions and 78,282 deletions.
2 changes: 2 additions & 0 deletions .bazelignore
Original file line number Diff line number Diff line change
@@ -22,4 +22,6 @@ dotnet/src/webdriver/obj
java/build/production
java/client/build
java/server/build
javascript/grid-ui/node_modules
javascript/node/selenium-webdriver/node_modules
node_modules
33 changes: 23 additions & 10 deletions .bazelrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
try-import .bazelrc.local
try-import .bazelrc.windows.local

# Disable bzlmod until we're ready to use it
common --noenable_bzlmod

# Ensure Windows support is accurate.

startup --windows_enable_symlinks
@@ -25,13 +28,24 @@ build --javacopt="--release 11"
build --experimental_strict_java_deps=strict
build --explicit_java_test_deps

# Ensure builds are unpolluted by the user env
# Allow spaces in runfile paths
build --nobuild_runfile_links

build --incompatible_strict_action_env
# More JS magic
build --experimental_allow_unresolved_symlinks

# Required for faster TS builds
build --@aspect_rules_ts//ts:skipLibCheck=always
fetch --@aspect_rules_ts//ts:skipLibCheck=always
query --@aspect_rules_ts//ts:skipLibCheck=always

# Except for the PATH environment variable
build --@aspect_rules_ts//ts:default_to_tsc_transpiler
fetch --@aspect_rules_ts//ts:default_to_tsc_transpiler
query --@aspect_rules_ts//ts:default_to_tsc_transpiler

build --action_env=PATH
# Ensure builds are unpolluted by the user env

build --incompatible_strict_action_env

# For build stamping

@@ -53,7 +67,6 @@ test --test_env=DISPLAY
test --test_env=FIREFOX_NIGHTLY_BINARY
test --test_env=GITHUB_ACTIONS
test --test_env=MOZ_HEADLESS
test --test_env=PATH # Remove once browser pinning works
test --test_env=SELENIUM_BROWSER
test --test_env=TRAVIS
test --test_env=PYTHON_VERSION
@@ -70,8 +83,8 @@ test --test_env=JRUBY_OPTS="--dev"

# JRuby/TruffleRuby: https://github.com/jruby/jruby/issues/5661

build --action_env=HOME
test --test_env=HOME
#build --action_env=HOME
#test --test_env=HOME

# Expose necessary variables for Selenium-Manager.

@@ -94,7 +107,7 @@ build:remote --remote_cache=grpcs://gypsum.cluster.engflow.com
build:remote -j 50

# Build Without The Bytes
build:remote --remote_download_outputs=minimal
build:remote --remote_download_minimal

build:remote --define=EXECUTOR=remote
build:remote --experimental_inmemory_dotd_files
@@ -137,8 +150,8 @@ build:remote --//common:pin_browsers
# The remote build machines are pretty small, and 50 threads may leave them
# thrashing, but our dev machines are a lot larger. Scale the workload so we
# make reasonable usage of everything, everywhere, all at once.
build:remote --local_cpu_resources='HOST_CPUS*10'
build:remote --local_ram_resources='HOST_RAM*4.0'
build:remote --local_resources=cpu='HOST_CPUS*10'
build:remote --local_resources=memory='HOST_RAM*4.0'

# A small hint that we're running our tests remotely
test:remote --test_env=REMOTE_BUILD=1
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.5.0
7.1.0
9 changes: 9 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// https://containers.dev/implementors/json_reference/

{
"name": "selenium-devcontainer",
"build": {
"dockerfile": "../scripts/dev-image/Dockerfile"
},
"runArgs": ["--name", "selenium_devcontainer"]
}
4 changes: 2 additions & 2 deletions .github/workflows/bazel.yml
Original file line number Diff line number Diff line change
@@ -95,7 +95,7 @@ jobs:
distribution: 'temurin'
- name: Setup Bazel with caching
if: inputs.caching
uses: p0deje/setup-bazel@0.6.0
uses: bazel-contrib/setup-bazel@0.8.1
with:
bazelisk-cache: true
bazelrc: common --color=yes
@@ -110,7 +110,7 @@ jobs:
repository-cache: true
- name: Setup Bazel without caching
if: inputs.caching == false
uses: p0deje/setup-bazel@0.6.0
uses: bazel-contrib/setup-bazel@0.8.1
with:
bazelrc: common --color=yes
- name: Setup Fluxbox and Xvfb
36 changes: 30 additions & 6 deletions .github/workflows/ci-java.yml
Original file line number Diff line number Diff line change
@@ -5,22 +5,47 @@ on:
workflow_dispatch:

jobs:
browser-tests:
browser-tests-windows:
name: Browser Tests
uses: ./.github/workflows/bazel.yml
strategy:
fail-fast: false
matrix:
include:
- os: windows
with:
name: Browser Tests (chrome, ${{ matrix.os }})
os: ${{ matrix.os }}
browser: chrome
cache-key: java-${{ matrix.os }}-tests
run: |
bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest `
//java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest `
//java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest `
//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest `
//java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest `
//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest
browser-tests-macos:
name: Browser Tests
uses: ./.github/workflows/bazel.yml
strategy:
fail-fast: false
matrix:
include:
- os: macos
with:
name: Browser Tests (chrome, ${{ matrix.os }})
os: ${{ matrix.os }}
browser: chrome
cache-key: java-${{ matrix.os }}-tests
run: >
bazel test //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest
run: |
bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote \
//java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest \
//java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest \
//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest \
//java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest \
//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest
remote-tests:
name: Remote Tests
@@ -29,12 +54,11 @@ jobs:
fail-fast: false
matrix:
include:
- os: windows
- os: macos
with:
name: Remote Tests (chrome, ${{ matrix.os }})
os: ${{ matrix.os }}
browser: chrome
cache-key: java-${{ matrix.os }}-remote-tests
run: >
bazel test //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote
run: |
bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote
20 changes: 1 addition & 19 deletions .github/workflows/ci-javascript.yml
Original file line number Diff line number Diff line change
@@ -28,22 +28,4 @@ jobs:
cache-key: node
run: |
export SELENIUM_BROWSER=${{ matrix.browser }}
bazel test --flaky_test_attempts 3 //javascript/node/selenium-webdriver:tests
# As soon as this gets merged https://github.com/facebook/jest/pull/9351, we should upgrade Jest and
# run bazel test javascript/grid-ui:test for these tests
grid-ui:
name: Grid UI Tests
needs: build
runs-on: ubuntu-latest
steps:
- name: Checkout source tree
uses: actions/checkout@v4
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
- name: NPM install
run: cd javascript/grid-ui && npm install
- name: Run unit tests
run: cd javascript/grid-ui && npm test
bazel test --flaky_test_attempts 3 //javascript/node/selenium-webdriver:${{matrix.browser}}-browser-tests
19 changes: 13 additions & 6 deletions .github/workflows/ci-ruby.yml
Original file line number Diff line number Diff line change
@@ -56,7 +56,11 @@ jobs:
cache-key: rb-unit-test-${{ matrix.ruby-version }}
os: ${{ matrix.os }}
ruby-version: ${{ matrix.ruby-version }}
run: bazel test //rb/spec/unit/...
run: >
bazel test
--build_tests_only
--test_size_filters small
//rb/spec/...
integration-tests-local:
name: Local Tests
@@ -90,10 +94,12 @@ jobs:
os: ${{ matrix.os }}
run: >
bazel test
--define browser=${{ matrix.browser }}
--build_tests_only
--flaky_test_attempts 3
--local_test_jobs 1
//rb/spec/integration/...
--test_size_filters large
--test_tag_filters ${{ matrix.browser }}
//rb/spec/...
integration-tests-remote:
name: Remote Tests
@@ -119,8 +125,9 @@ jobs:
java-version: 11
run: >
bazel test
--define browser=${{ matrix.browser }}
--define remote=true
--build_tests_only
--flaky_test_attempts 3
--local_test_jobs 1
//rb/spec/integration/...
--test_size_filters large
--test_tag_filters ${{ matrix.browser }}-remote
//rb/spec/...
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ jobs:
with:
fetch-depth: 50
- name: Setup Bazel
uses: p0deje/setup-bazel@0.4.0
uses: bazel-contrib/setup-bazel@0.8.1
with:
bazelisk-cache: true
external-cache: |
4 changes: 2 additions & 2 deletions .github/workflows/lock.yml
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ name: 'Lock Issues'
on:
workflow_dispatch:
schedule:
- cron: '0 0 * * *'
- cron: '45 22 * * *'

permissions:
issues: write
@@ -22,5 +22,5 @@ jobs:
issue-lock-reason: ''
issue-comment: >
This issue has been automatically locked since there
has not been any recent activity after it was closed.
has not been any recent activity since it was closed.
Please open a new issue for related bugs.
4 changes: 3 additions & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
@@ -47,7 +47,9 @@ jobs:
cache-key: python-nightly
run: |
./go "py:version[nightly]"
./go py:release
./go py:build
pip install twine
twine upload --repository testpypi bazel-bin/py/selenium-4*.whl bazel-bin/py/selenium-4*.tar.gz
secrets: inherit


11 changes: 9 additions & 2 deletions .github/workflows/stale.yml
Original file line number Diff line number Diff line change
@@ -16,11 +16,18 @@ jobs:
pull-requests: write # for actions/stale to close stale PRs
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v8
- uses: actions/stale@v9
with:
stale-issue-message: 'This issue is stale because it has been open 280 days with no activity. Remove stale label or comment or this will be closed in 14 days.'
close-issue-message: 'This issue was closed because it has been stalled for 14 days with no activity.'
stale-issue-label: 'I-stale'
days-before-stale: 280
days-before-close: 14
operations-per-run: 200
- uses: actions/stale@v9
with:
close-issue-message: 'This issue was closed because we did not receive any additional information after 14 days.'
stale-issue-label: 'R-awaiting answer'
days-before-stale: -1
days-before-close: 14
labels-to-add-when-unstale: 'needs-triaging'

2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@ junitvmwatcher*.properties
test-output/
.*.swp
*~
.aspect/
common/build
/build/
cpp/iedriver/IEReturnTypes.h
@@ -135,3 +136,4 @@ bazel-testlogs
javascript/node/selenium-webdriver/.vscode/settings.json

dotnet-bin
.metadata/
6 changes: 6 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Disabling pnpm [hoisting](https://pnpm.io/npmrc#hoist) by setting `hoist=false` is recommended on
# projects using rules_js so that pnpm outside of Bazel lays out a node_modules tree similar to what
# rules_js lays out under Bazel (without a hidden node_modules/.pnpm/node_modules). See
# https://github.com/aspect-build/rules_js/blob/7377f2d0387cc2a9251137929b1c53ccdb3fbcf0/docs/npm_import.md#npm_translate_lock
# documentation for more information.
hoist=false
27 changes: 10 additions & 17 deletions .skipped-tests
Original file line number Diff line number Diff line change
@@ -1,33 +1,26 @@
-//dotnet/test/common:DevTools/DevToolsNetworkTest-chrome
-//dotnet/test/common:Interactions/BasicMouseInterfaceTest-chrome
-//dotnet/test/common:Interactions/BasicMouseInterfaceTest-firefox
-//dotnet/test/common:JavascriptEnabledBrowserTest-chrome
-//dotnet/test/common:NetworkInterceptionTests-chrome
-//dotnet/test/common:TakesScreenshotTest-chrome
-//dotnet/test/common:TakesScreenshotTest-firefox
-//dotnet/test/common:VirtualAuthn/VirtualAuthenticatorTest-chrome
-//dotnet/test/support/UI:SelectBrowserTests-firefox
-//dotnet/test/support/UI:SelectTests
-//java/test/org/openqa/selenium/bidi/browsingcontext:BrowsingContextTest
-//java/test/org/openqa/selenium/bidi/browsingcontext:BrowsingContextTest-remote
-//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest
-//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote
-//java/test/org/openqa/selenium/edge:EdgeDriverFunctionalTest
-//java/test/org/openqa/selenium/edge:EdgeDriverFunctionalTest-edge
-//java/test/org/openqa/selenium/edge:EdgeDriverFunctionalTest-remote
-//java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest
-//java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest
-//java/test/org/openqa/selenium/grid/gridui:OverallGridTest
-//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest
-//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest-chrome
-//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest-chrome-remote
-//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest-edge
-//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest-edge-remote
-//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest-remote
-//java/test/org/openqa/selenium/interactions:DefaultMouseTest
-//java/test/org/openqa/selenium/interactions:DefaultMouseTest-remote
-//java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest
-//java/test/org/openqa/selenium/remote:RemoteWebDriverScreenshotTest-remote
-//javascript/atoms:test-chrome
-//javascript/atoms:test-edge
-//javascript/atoms:test-firefox-beta
-//javascript/atoms:test-firefox-dev
-//py:common-chrome-test/selenium/webdriver/common/virtual_authenticator_tests.py
-//py:test-chrome-test/selenium/webdriver/chrome/chrome_launcher_tests.py
-//py:test-chrome-test/selenium/webdriver/chrome/chrome_service_tests.py
-//py:test-chrome-test/selenium/webdriver/chrome/proxy_tests.py
-//py:unit-test/unit/selenium/webdriver/common/cdp_module_fallback_tests.py
-//rb/spec/integration/selenium/webdriver/chrome:service-chrome
-//rb/spec/integration/selenium/webdriver/edge:service-edge
-//rb/spec/integration/selenium/webdriver/firefox:service-firefox
-//rb/spec/integration/selenium/webdriver/firefox:service-firefox-beta
Loading