Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ruby][bidi] Add LogInspector #11368

Merged
merged 5 commits into from Dec 20, 2022
Merged

[ruby][bidi] Add LogInspector #11368

merged 5 commits into from Dec 20, 2022

Conversation

TamsilAmani
Copy link
Contributor

@TamsilAmani TamsilAmani commented Dec 5, 2022 •
edited

Description

Add LogInspector contains the w3c Bidi spec related APIs to listen to log events.

Motivation and Context

Refer to BiDi Spec Doc about the details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@TamsilAmani TamsilAmani changed the title [ruby][bidi] Listening to events [ruby][bidi] Add LogInspector Dec 7, 2022
@TamsilAmani TamsilAmani marked this pull request as ready for review December 7, 2022 11:17
p0deje
p0deje approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@p0deje p0deje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left few small suggestions.

rb/lib/selenium/webdriver/bidi/log_inspector.rb Outdated Show resolved Hide resolved
rb/lib/selenium/webdriver/bidi/log_inspector.rb Outdated Show resolved Hide resolved
rb/lib/selenium/webdriver/bidi/log_inspector.rb Outdated Show resolved Hide resolved
rb/lib/selenium/webdriver/bidi/log_inspector.rb Outdated Show resolved Hide resolved
rb/lib/selenium/webdriver/bidi/log_inspector.rb Outdated Show resolved Hide resolved
rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb Show resolved Hide resolved
rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb Outdated Show resolved Hide resolved
rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb Outdated Show resolved Hide resolved
rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb Outdated Show resolved Hide resolved
rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb Outdated Show resolved Hide resolved
@titusfortner titusfortner added this to the 4.8 milestone Dec 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pujagani added a commit that referenced this pull request Dec 19, 2022
@pujagani
[java][bidi] Rename 'onConsoleLog' to 'onConsoleEntry'
2443d5a 
Discussed in #11368 (comment)
@pujagani pujagani merged commit 12f0d19 into SeleniumHQ:trunk Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomatedTester AutomatedTester AutomatedTester left review comments

@titusfortner titusfortner titusfortner left review comments

@p0deje p0deje p0deje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TamsilAmani @AutomatedTester @p0deje @titusfortner @pujagani