Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Fix wrongly trying to load a constant #11931

Merged
merged 1 commit into from Apr 23, 2023
Merged

[rb] Fix wrongly trying to load a constant #11931

merged 1 commit into from Apr 23, 2023

Conversation

boris-petrov
Copy link
Contributor

Description

There was one } too many.

Motivation and Context

Otherwise people get:

NameError:
       wrong constant name Selenium::DevTools::V112::Target}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner merged commit 542f0a1 into SeleniumHQ:trunk Apr 23, 2023
25 checks passed
@titusfortner
Copy link
Member

thanks!

@boris-petrov boris-petrov deleted the fix-typo branch April 23, 2023 14:32
dev-ardi pushed a commit to dev-ardi/selenium that referenced this pull request Apr 24, 2023
@halo
Copy link

halo commented Apr 25, 2023

It took me a while googling this exact error:

NameError:
  wrong constant name Target}

But I finally got here 😄 Thank you for fixing this!

@mihael
Copy link

mihael commented Apr 27, 2023

I am trying to intercept requests and hit this problem. And no, even with this fix, interception still won't work.

@titusfortner
Copy link
Member

Replying to a closed issue with a different problem is not helpful. It it's a bug, please open a new issue with all of the requested details.

@p0deje
Copy link
Member

p0deje commented May 2, 2023

@boris-petrov Such a silly mistake from me, thanks for fixing!

@ylecuyer
Copy link

ylecuyer commented May 2, 2023

Is a release of the gem with the fix planned?

@p0deje
Copy link
Member

p0deje commented May 2, 2023

@ylecuyer Chrome 113 should be released today. After that, we'll ship a new selenium-devtools release.

@mihael
Copy link

mihael commented May 15, 2023

Replying to a closed issue with a different problem is not helpful.

Apologies @titusfortner, you are right!

I've created an issue: #12040 for my problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants