Change Ruby Logging #11967
Change Ruby Logging #11967
Conversation
|
I'm looking through https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/, but I don't see what exactly we should match in Ruby. Can you point to Java/Python/etc examples? |
|
I meant the levels.
Right now I wish Ruby had more "debug" levels like the other languages, but alas. |
| # | ||
| # @param [Array, Symbol] id | ||
| # | ||
| def select(id) |
|
|
||
| warn message, &block | ||
| @logger.warn { message } |
There was a problem hiding this comment.
The code is very similar to #discard_or_log. I suggest you refactor it so that it accepts @reject/@select as the parameters. Then you can simply call this method with an extra :deprecations id.
|
I fixed the things you suggested, including changing the names. I'd prefer Arrays to Sets still just because that's what people are more used to... Methods now accept one or more params and Arrays. I also added logic for setting the default level in constructor. Webdrivers gem and Watir both use the Selenium Logger, and don't want to force the change on them? |
My proposal was to convert arrays to sets internally, not to force people into using sets. |
titusfortner
force-pushed
the
log_rb
branch
3 times, most recently
from
06dec92
to
fb6622f
Compare
…ects can keep existing behavior
the io accessor for the process sets a default value, so assigning with ||= operator will never work
Description
Change default logging level to
:infoand provide more granular filtering optionsMotivation and Context
I'm looking at how logging is being done in other languages, and as part of putting this documentation together - https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/ I thought we should change our implementation to match the other languages.
Details:
To better manage the flood of details now in
:debugmode, I've added#selectand#rejectmethods where you can opt in or opt out of specific types of logs.Let me know if all of these choices make sense.