[py] Rounded pause duration

[Dakkaron]

WebDriver standard expects "duration" parameter of "pause" action to be integer. ChromeDriver does not care, but GeckoDriver is very strict on this. See mozilla/geckodriver#1355

• By placing an X in the preceding checkbox, I verify that I have signed the Contributor License Agreement

[cgoldberg]

@Dakkaron
Do you have a good reason for why this should be changed?

currently, passing a non-integer will raise a InvalidArgumentException with a clear message that 'duration' was not a positive integer.

Following the principles of "exclicit is better than implicit" and "errors should never pass silently", I feel like that behavior is more correct than implicitly rounding duration to an integer.

[Dakkaron]

In Selenium for Python the pause action takes seconds as parameter, while the WebDriver protocol takes milliseconds. To convert that, the Selenium for Python implementation multiplies the input by 1000.

If you want to wait for fractions of seconds, this is currently not possible (as laid out in the linked thread), because what happens there is you pass 0.5 seconds, these get multiplied to 500.0 milliseconds. The problem here is that when you multiply an integer by a float you get a float, not an integer, so this raises said exception.

There is no way to pass fractions of a second as an integer second value.

The ChromeDriver is very lax on the standard and allows floats there, but GeckoDriver is very strict and forbids floats here.

Because of this, it is absolutely necessary to allow floats and cast them to int, except you want to rework Selenium so that pause takes milliseconds (as the WebDriver protocol do), which would break existing tests.

[Dakkaron]

This problem also has been reported here #6295.

[lmtierney]

@Dakkaron thanks for the explanation. We definitely want to allow fractions of a second. I don't think we need the round() but am indifferent on it. The difference would be half a millisecond

[Dakkaron]

@lmtierney Thanks for the answer. Should I remove the round()?

[lmtierney]

@Dakkaron yeah go ahead and remove the round and I'll get it merged

[Dakkaron]

@lmtierney Did it, can be merged now. Thank you!

[lmtierney]

Merged, thank you for your contribution!

[Dakkaron]

Thank you!