Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal css broken #47

Open
kcpradyp opened this issue Mar 20, 2018 · 3 comments
Open

modal css broken #47

kcpradyp opened this issue Mar 20, 2018 · 3 comments

Comments

@kcpradyp
Copy link

kcpradyp commented Mar 20, 2018

Codepen reproduce

https://codesandbox.io/s/xj4rx88yzz

@gpascale
Copy link

I was tearing my hair out over this one. I believe the issue has to do with the overzealous rule:

.visible.transition { display: block !important; }

This causes the modal's container to have display: block instead of display: flex. Thus, the modal doesn't flex itself into place properly.

See attached photos showing how disabling this rule fixes the positioning:

broken1
broken2

My pen here: https://codepen.io/gpascale/full/VXbxMN/

@gpascale
Copy link

As a temporary workaround, I've stuck the following in my code, and it seems to work:

.dimmer.visible.transition {
  display: flex !important;
}

@jamesjryan
Copy link

@gpascale perfect timing, thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants