Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a release with addon configuration bugfix to enable themeing #247

Open
jenweber opened this issue Feb 21, 2019 · 2 comments
Open

Make a release with addon configuration bugfix to enable themeing #247

jenweber opened this issue Feb 21, 2019 · 2 comments

Comments

@jenweber
Copy link
Contributor

Hi! My PR #242 was merged, but it would be helpful to have this as a release available on npm. Are there any blockers I can help with? I'm happy to help write a CHANGELOG, release notes, etc.

I question whether it should be a major or patch release. It's technically a bugfix, but I suspect that some long-term users may have extra config hanging around that was never actually picked up, and applying the new "patch" level release could have unexpected consequences. To be totally safe and de-risk weird behavior, it might be worth considering this as a major version (4.0.0).

Thanks!

@vogelbek
Copy link

vogelbek commented Apr 3, 2019

Good work @jenweber, thanks for figuring this out!

Does anyone know a way to sidestep the NPM release and instruct ember to install this directly from the master branch until a 3.0.4 (3.1? 4.0?!) comes out?

I tried ember install https://github.com/Semantic-Org/Semantic-UI-Ember.git, but it still doesn't appear to accept theme changes.

@jenweber
Copy link
Contributor Author

jenweber commented Apr 3, 2019

@vogelbek I have found that npm handles installs from GitHub kinda weirdly. I sometimes had to delete the entry from package-lock.json and delete the directory in a project's node_modules in order to force it to drop the "old" version and install from GitHub.

Then in your package.json, I think you can do something like "package": "git+https://github.com/username/package.git#commithash"

I would not recommend installing straight from the master branch because if someone else's (possibly breaking) changes get merged in that you aren't expecting, it could go badly.

I'll see if I can help the maintainers get this out in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants