Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransitionablePortal: onClose is called even on button click when controlled #4056

Open
lainermeister opened this issue Sep 3, 2020 · 2 comments · May be fixed by #4334
Open

TransitionablePortal: onClose is called even on button click when controlled #4056

lainermeister opened this issue Sep 3, 2020 · 2 comments · May be fixed by #4334
Labels
bug

Comments

@lainermeister
Copy link

lainermeister commented Sep 3, 2020 •
edited

Bug Report

Steps

In this sandbox, click Open Portal, then click Close Portal. Check the console.
https://codesandbox.io/s/happy-drake-yly34?file=/example.js

Expected Result

One callback of onClose triggered

CB triggered: Button closed

Actual Result

Two callbacks of onClose triggered

CB triggered: Button closed 
CB triggered: Portal closed

Version

"semantic-ui-react": "1.2.1"

Testcase

https://codesandbox.io/s/happy-drake-yly34?file=/example.js
@welcome
Copy link

welcome bot commented Sep 3, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter layershifter changed the title TransitionablePortal onClose is called even on button click when controlled TransitionablePortal: onClose is called even on button click when controlled Sep 7, 2020
@srid12
Copy link

srid12 commented Oct 14, 2020

I would like to solve it

@mterezac mterezac linked a pull request Feb 15, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(TransitionablePortal): fix onClose call mterezac/Semantic-UI-React
3 participants
@srid12 @layershifter @lainermeister