Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] should not throw findDOMNode warning in browser #4396

Closed
codewizard-dt opened this issue Oct 28, 2022 · 6 comments
Closed

[Button] should not throw findDOMNode warning in browser #4396

codewizard-dt opened this issue Oct 28, 2022 · 6 comments

Comments

@codewizard-dt
Copy link

[Button] should not throw findDOMNode warning in browser

Steps

  • Be using React ^18 in StrictMode
  • Add Button component to a page
  • Open Dev Tools and look at console

Expected Result

There should be no warnings

Actual Result

There is a big red warning

react-dom.development.js:86 Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of RefFindNode which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
    at button
    at RefFindNode (http://localhost:3000/static/js/bundle.js:2245:35)
    at Ref (http://localhost:3000/static/js/bundle.js:2186:24)
    at Button (http://localhost:3000/static/js/bundle.js:66088:29)

Version

Semantic-UI-React 2.1.3
React ^18.2

@welcome
Copy link

welcome bot commented Oct 28, 2022

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@yveslange
Copy link

Same issue for multiple other components (Dimmer, ...)

@layershifter
Copy link
Member

layershifter commented Apr 11, 2023

Please try the latest beta i.e. semantic-ui-react@3.0.0-beta.0, it does not use findDOMNode anymore.

@yveslange
Copy link

Using 3.0.0-beta.0 with semantic-ui-css@^2.5.0 fixed the issue. Thanks @layershifter

@achimkoellner
Copy link

@layershifter when will v3 be considered stable?

@layershifter
Copy link
Member

@achimkoellner once issues from #4409 will be resolved.


Closing this as the problem is resolved in the latest beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants