Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README.md): fix formatting #3958

Merged
merged 2 commits into from Jul 17, 2020
Merged

Conversation

klunico
Copy link
Contributor

@klunico klunico commented Jun 3, 2020

No description provided.

@welcome
Copy link

welcome bot commented Jun 3, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #3958 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3958      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files         183      178       -5     
  Lines        3157     3150       -7     
==========================================
- Hits         3152     3145       -7     
  Misses          5        5              
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100.00% <0.00%> (ø)
src/modules/Transition/Transition.js 100.00% <0.00%> (ø)
src/behaviors/Visibility/Visibility.js 100.00% <0.00%> (ø)
src/modules/Transition/TransitionGroup.js 100.00% <0.00%> (ø)
...ddons/TransitionablePortal/TransitionablePortal.js 100.00% <0.00%> (ø)
src/modules/Transition/utils/wrapChild.js
src/modules/Dropdown/utils/getSelectedIndex.js
src/modules/Dropdown/utils/getMenuOptions.js
src/modules/Transition/utils/childMapping.js
src/modules/Transition/utils/computeStatuses.js
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8def5...b4b1b2f. Read the comment docs.

@layershifter layershifter changed the title Update README.md docs(README.md): fix formatting Jul 17, 2020
@layershifter layershifter merged commit 513f70e into Semantic-Org:master Jul 17, 2020
@welcome
Copy link

welcome bot commented Jul 17, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants