Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ModernAutoControlled component #3967

Merged
merged 1 commit into from Jun 24, 2020
Merged

Conversation

layershifter
Copy link
Member

Related to #3919.

Removes the usage of UNSAFE_componentWillReceiveProps for:

  • Pagination
  • Portal
  • Menu
  • AccordionAccordion
  • Checkbox
  • Embed
  • Modal
  • Rating
  • Tab

There are only components remaining that are using old AutoControlledComponent: Dropdown and Search. Due complexity with them these usages will be addressed in separate PRs.

@codecov-commenter
Copy link

Codecov Report

Merging #3967 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3967   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         178      178           
  Lines        3152     3152           
=======================================
  Hits         3147     3147           
  Misses          5        5           
Impacted Files Coverage Δ
src/addons/Pagination/Pagination.js 100.00% <100.00%> (ø)
src/addons/Portal/Portal.js 100.00% <100.00%> (ø)
src/collections/Menu/Menu.js 100.00% <100.00%> (ø)
src/modules/Accordion/AccordionAccordion.js 100.00% <100.00%> (ø)
src/modules/Checkbox/Checkbox.js 100.00% <100.00%> (ø)
src/modules/Embed/Embed.js 100.00% <100.00%> (ø)
src/modules/Modal/Modal.js 100.00% <100.00%> (ø)
src/modules/Rating/Rating.js 100.00% <100.00%> (ø)
src/modules/Tab/Tab.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad47a6b...9677283. Read the comment docs.

@layershifter layershifter merged commit 4c0ecc7 into master Jun 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/use-modern-acc branch June 24, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants