Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Search): replace deprecated lifecycle methods #3968

Merged
merged 2 commits into from Jun 24, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jun 24, 2020

Related to #3919.

This PR moves Search to use ModernAutoControlled component and removes usage of UNSAFE_componentWillMount() & UNSAFE_componentWillReceiveProps().

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #3968 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3968      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files         178      178              
  Lines        3152     3148       -4     
==========================================
- Hits         3147     3143       -4     
  Misses          5        5              
Impacted Files Coverage Δ
src/modules/Search/Search.js 99.53% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0ecc7...d11cee4. Read the comment docs.

@layershifter layershifter merged commit bd92e01 into master Jun 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/search-no-dep-methods branch June 24, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants