Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Visibility): remove usage of deprecated lifecycle methods #3973

Merged
merged 1 commit into from Jun 29, 2020

Conversation

layershifter
Copy link
Member

Related to #3919.

Removes the usage of UNSAFE_componentWillReceiveProps for Visibility.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020

Codecov Report

Merging #3973 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3973   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         178      180    +2     
  Lines        3148     3171   +23     
=======================================
+ Hits         3143     3166   +23     
  Misses          5        5           
Impacted Files Coverage Δ
src/modules/Transition/utils/childMapping.js 100.00% <ø> (ø)
src/behaviors/Visibility/Visibility.js 100.00% <100.00%> (ø)
src/modules/Transition/TransitionGroup.js 100.00% <100.00%> (ø)
src/modules/Transition/utils/wrapChild.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d83ac1...2870f9c. Read the comment docs.

@layershifter layershifter merged commit 9adb4bf into master Jun 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/visibility-no-dep branch June 29, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants