Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use react-intersection-observer in docs to improve perf #3985

Merged
merged 7 commits into from Jul 15, 2020
Merged

chore: use react-intersection-observer in docs to improve perf #3985

merged 7 commits into from Jul 15, 2020

Conversation

knight-coder-llc
Copy link
Contributor

@knight-coder-llc knight-coder-llc commented Jul 14, 2020

Fixes #3978.

Added react intersection observer to docs component examples to improve cpu usage over getBoundingRect function call. Replaced react visibility sensor.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #3985 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3985   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         181      180    -1     
  Lines        3168     3169    +1     
=======================================
+ Hits         3163     3164    +1     
  Misses          5        5           
Impacted Files Coverage Δ
src/modules/Transition/Transition.js 100.00% <0.00%> (ø)
...ddons/TransitionablePortal/TransitionablePortal.js 100.00% <0.00%> (ø)
src/modules/Transition/utils/computeStatuses.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9a7c7...5d66361. Read the comment docs.

@layershifter layershifter changed the title React intersection observer chore: use react-intersection-observer in docs to improve perf Jul 15, 2020
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed few more changes, LGTM. Also verified SSR scenario for docs, works as expected

Thanks ❤️

@layershifter layershifter merged commit d7ef80a into Semantic-Org:master Jul 15, 2020
@welcome
Copy link

welcome bot commented Jul 15, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The docs (https://react.semantic-ui.com) cause excessive CPU usage in Chrome
3 participants