From 0ed43cc4a271294c8c059a8ed22c42d950fc65b8 Mon Sep 17 00:00:00 2001 From: reefman001 Date: Sat, 11 Jul 2020 22:36:03 -0400 Subject: [PATCH 1/6] added react-intersection-observer module --- package.json | 1 + yarn.lock | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/package.json b/package.json index 04c7a0f3aa..ec49802449 100644 --- a/package.json +++ b/package.json @@ -85,6 +85,7 @@ "keyboard-key": "^1.0.4", "lodash": "^4.17.15", "prop-types": "^15.7.2", + "react-intersection-observer": "^8.26.2", "react-is": "^16.8.6", "react-popper": "^1.3.4", "shallowequal": "^1.1.0" diff --git a/yarn.lock b/yarn.lock index 040526ed57..3137f5bf9a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10041,6 +10041,13 @@ react-hot-loader@^4, react-hot-loader@^4.12.11: shallowequal "^1.1.0" source-map "^0.7.3" +react-intersection-observer@^8.26.2: + version "8.26.2" + resolved "https://registry.yarnpkg.com/react-intersection-observer/-/react-intersection-observer-8.26.2.tgz#0562ff0c06b2b10e809190c2fa9b6ded656e6e16" + integrity sha512-GmSjLNK+oV7kS+BHfrJSaA4wF61ELA33gizKHmN+tk59UT6/aW8kkqvlrFGPwxGoaIzLKS2evfG5fgkw5MIIsg== + dependencies: + tiny-invariant "^1.1.0" + react-is@^16.6.0, react-is@^16.6.3, react-is@^16.7.0, react-is@^16.8.1, react-is@^16.8.6, react-is@^16.9.0: version "16.9.0" resolved "https://registry.yarnpkg.com/react-is/-/react-is-16.9.0.tgz#21ca9561399aad0ff1a7701c01683e8ca981edcb" @@ -11850,6 +11857,11 @@ tiny-invariant@^1.0.2: resolved "https://registry.yarnpkg.com/tiny-invariant/-/tiny-invariant-1.0.3.tgz#91efaaa0269ccb6271f0296aeedb05fc3e067b7a" integrity sha512-ytQx8T4DL8PjlX53yYzcIC0WhIZbpR0p1qcYjw2pHu3w6UtgWwFJQ/02cnhOnBBhlFx/edUIfcagCaQSe3KMWg== +tiny-invariant@^1.1.0: + version "1.1.0" + resolved "https://registry.yarnpkg.com/tiny-invariant/-/tiny-invariant-1.1.0.tgz#634c5f8efdc27714b7f386c35e6760991d230875" + integrity sha512-ytxQvrb1cPc9WBEI/HSeYYoGD0kWnGEOR8RY6KomWLBVhqz0RgTwVO9dLrGz7dC+nN9llyI7OKAgRq8Vq4ZBSw== + tiny-warning@^1.0.0: version "1.0.2" resolved "https://registry.yarnpkg.com/tiny-warning/-/tiny-warning-1.0.2.tgz#1dfae771ee1a04396bdfde27a3adcebc6b648b28" From fe44dc6f0bbccfc8f045617807d3580b783789c0 Mon Sep 17 00:00:00 2001 From: reefman001 Date: Sat, 11 Jul 2020 22:38:40 -0400 Subject: [PATCH 2/6] moved react-intersection-observer to devDependencies. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index ec49802449..8bb36b8acf 100644 --- a/package.json +++ b/package.json @@ -85,7 +85,6 @@ "keyboard-key": "^1.0.4", "lodash": "^4.17.15", "prop-types": "^15.7.2", - "react-intersection-observer": "^8.26.2", "react-is": "^16.8.6", "react-popper": "^1.3.4", "shallowequal": "^1.1.0" @@ -158,6 +157,7 @@ "react-docgen": "^4.1.0", "react-dom": "^16.9.0", "react-hot-loader": "^4.12.11", + "react-intersection-observer": "^8.26.2", "react-router": "^5.0.0", "react-router-dom": "^5.0.0", "react-source-render": "^3.0.0-5", From 267ac610f314fc0017f2641c9934220375b8c0de Mon Sep 17 00:00:00 2001 From: reefman001 Date: Sun, 12 Jul 2020 22:59:51 -0400 Subject: [PATCH 3/6] implemented react intersection observer in docs component examples. --- .../ComponentDoc/ComponentExample/ComponentExample.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js b/docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js index a0cddce957..ce63716975 100644 --- a/docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js +++ b/docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js @@ -3,7 +3,8 @@ import cx from 'classnames' import copyToClipboard from 'copy-to-clipboard' import PropTypes from 'prop-types' import React, { Component } from 'react' -import VisibilitySensor from 'react-visibility-sensor' +import { InView } from 'react-intersection-observer' + import { Checkbox, Grid, Label } from 'semantic-ui-react' import { examplePathToHash, scrollToAnchor } from 'docs/src/utils' @@ -168,11 +169,7 @@ class ComponentExample extends Component { } = this.state return ( - + this.handleVisibility(inView)}>
@@ -224,7 +221,7 @@ class ComponentExample extends Component { {isActiveHash && }
- + ) } } From 6de8e606d28d9ce9e7ca472b6dc16e07b8e6de95 Mon Sep 17 00:00:00 2001 From: reefman001 Date: Mon, 13 Jul 2020 21:48:16 -0400 Subject: [PATCH 4/6] added observer From 0c99ff6642e111fa0a43bcdc4fb9a45e2d317665 Mon Sep 17 00:00:00 2001 From: Oleksandr Fediashov Date: Wed, 15 Jul 2020 17:24:47 +0200 Subject: [PATCH 5/6] remove react-visibility-sensor --- package.json | 1 - yarn.lock | 7 ------- 2 files changed, 8 deletions(-) diff --git a/package.json b/package.json index 8bb36b8acf..e201fa03b2 100644 --- a/package.json +++ b/package.json @@ -165,7 +165,6 @@ "react-static-routes": "^1.0.0", "react-test-renderer": "^16.9.0", "react-universal-component": "^3.0.3", - "react-visibility-sensor": "^5.0.2", "rimraf": "^2.6.3", "satisfied": "^1.1.2", "semantic-ui-css": "^2.4.1", diff --git a/yarn.lock b/yarn.lock index 3137f5bf9a..3a0f06044d 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10215,13 +10215,6 @@ react-universal-component@^2.8.1, react-universal-component@^3.0.3: hoist-non-react-statics "^2.2.1" prop-types "^15.5.10" -react-visibility-sensor@^5.0.2: - version "5.0.2" - resolved "https://registry.yarnpkg.com/react-visibility-sensor/-/react-visibility-sensor-5.0.2.tgz#e360fff81572cb3a2a9fd680484447a9da09a55d" - integrity sha512-7+1lr7oQOO2vKr5u/uxoDGFWAAy7lsDy2aJU3Zy1/OymI+TRqOBk8m2L8YE1B0UyfCDWxVAWO+aifVGqNOvqeQ== - dependencies: - prop-types "^15.6.2" - react@^16, react@^16.9.0: version "16.9.0" resolved "https://registry.yarnpkg.com/react/-/react-16.9.0.tgz#40ba2f9af13bc1a38d75dbf2f4359a5185c4f7aa" From c011e72b22c0fc921db9f4783a058b4153e96914 Mon Sep 17 00:00:00 2001 From: Oleksandr Fediashov Date: Wed, 15 Jul 2020 17:26:23 +0200 Subject: [PATCH 6/6] remove closure --- .../ComponentDoc/ComponentExample/ComponentExample.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js b/docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js index ce63716975..d945ecf1fc 100644 --- a/docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js +++ b/docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js @@ -169,7 +169,7 @@ class ComponentExample extends Component { } = this.state return ( - this.handleVisibility(inView)}> +