Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dropdown): remove deprecated lifecycle methods #3986

Merged
merged 3 commits into from Jul 15, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jul 15, 2020

Fixes #3919.

This PR removes AutoControlledComponent & removes the usage of deprecated lifecycle methods from Dropdown.

@codecov-commenter
Copy link

Codecov Report

Merging #3986 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3986      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files         181      183       +2     
  Lines        3168     3157      -11     
==========================================
- Hits         3163     3152      -11     
  Misses          5        5              
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100.00% <100.00%> (ø)
src/modules/Dropdown/utils/getMenuOptions.js 100.00% <100.00%> (ø)
src/modules/Dropdown/utils/getSelectedIndex.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ef80a...4a5a34b. Read the comment docs.

@layershifter layershifter merged commit be8def5 into master Jul 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/remove-deprecated-methods branch July 15, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UNSAFE_componentWillReceiveProps lifecycle method now throws a warning in newer versions of React
2 participants