Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.0: Build reporting less compile issues #7095

Open
mcrawshaw opened this issue Oct 20, 2022 · 1 comment
Open

v2.5.0: Build reporting less compile issues #7095

mcrawshaw opened this issue Oct 20, 2022 · 1 comment

Comments

@mcrawshaw
Copy link

mcrawshaw commented Oct 20, 2022

Due to updates in the less dependency some math operations are more strict (https://github.com/less/less.js/releases/tag/v4.0.0).

Steps

Build semantic

Actual Result

[PluginError: Error evaluating function `unit`: the first argument to unit must be a number. Have you forgotten parenthesis? in file ./semantic/src/themes/default/globals/site.variables line no. 393] {
  stack: undefined,
  type: 'Argument',
  filename: './semantic/src/themes/default/globals/site.variables',
  index: 10061,
  line: 393,
  column: 19,
  callLine: NaN,
  callExtract: undefined,
  extract: [
    '*/',
    '@mini            : unit( round(@miniSize * @emSize) / @emSize, rem);',
    '@tiny            : unit( round(@tinySize * @emSize) / @emSize, rem);'
  ],
  lineNumber: 393,
  fileName: './semantic/src/themes/default/globals/site.variables',
  __safety: { toString: [Function: bound ] },
  _stack: undefined,
  plugin: 'gulp-less',
  showProperties: true,
  showStack: false
}

Version

2.5.0

Recommendation

There are a couple of updates needed in the theme less files. Wrap division expressions in parentheses and variables prefixed with negative signs must also be wrapped.

@mcrawshaw mcrawshaw changed the title v2.5.0: Build reporting less compile issues v2.5.0: Build reporting LESS compile issues Oct 20, 2022
@mcrawshaw mcrawshaw changed the title v2.5.0: Build reporting LESS compile issues v2.5.0: Build reporting less compile issues Oct 20, 2022
@soilsk
Copy link

soilsk commented Dec 9, 2022

For now ... maybe: npm install less@3.7.1 --save-dev ?

emertechie added a commit to brandchamp/portal-vue-semantic that referenced this issue Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants