Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion does not close on first click #473

Open
1 of 3 tasks
joerattz opened this issue Aug 10, 2020 · 2 comments
Open
1 of 3 tasks

Accordion does not close on first click #473

joerattz opened this issue Aug 10, 2020 · 2 comments

Comments

@joerattz
Copy link

Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.

  • I'm submitting a ...
    • bug report
    • feature request
    • support request => Please do not submit support request here, see note at the top of this template.
  • Do you want to request a feature or report a bug?
    Report a bug.
  • What is the current behavior?
    Clicking an accordion's trigger requires clicking it twice if it starts opened. If the accordion starts closed, clicking it once opens it.
  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via

You can reproduce this by going to the Semantic UI Vue page for the accordion component: https://semantic-ui-vue.github.io/#/modules/accordion

Click any of the examples where the accordion starts opened and you must click it twice to close it.

However, clicking on an accordion that starts closed doesn't require clicking it twice. The Form Fields example on the Semantic UI Vue accordion page demonstrates this.

Also, I checked the accordion component on the Semantic UI React page and it doesn't require you to click the trigger twice if the accordion starts opened.

  • What is the expected behavior?

Clicking the accordion trigger once should cause it to close.

  • What is the motivation / use case for changing the behavior?

So users don't have to click it more than once to close the accordion when it starts open.

  • Please tell us about your environment:

    • Version: 84.0.4147.105 (Official Build) (64-bit)
    • Browser: [Chrome]
    • Language: [ES5]
    • Windows 10
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
@joerattz
Copy link
Author

Here's a work-around I discovered.

<sui-accordion-title active ref="accordion">

mounted: function () { this.$refs.accordion.toggle(); },

@cperezcapote
Copy link

I can work on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants