Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased karma loss is decreasing karma loss #5017

Open
legendsofsosaria opened this issue Jul 30, 2022 · 1 comment
Open

Increased karma loss is decreasing karma loss #5017

legendsofsosaria opened this issue Jul 30, 2022 · 1 comment

Comments

@legendsofsosaria
Copy link

Increased karma loss is currently making you lose less karma instead of more

@legendsofsosaria
Copy link
Author

legendsofsosaria commented Jul 30, 2022

The math in necromancerspell.cs
karma += AOS.Scale(karma, AosAttributes.GetValue(this.Caster, AosAttribute.IncreasedKarmaLoss));
is canceling out the math in titles.cs

if (karmaLoss != 0 && offset < 0)
            {
                offset -= (int)(offset * (karmaLoss / 100.0));
            }

if you actually run numbers through this formula it decreases your karma loss instead of increasing. Tested with wither, instead of returning 125 with 25% karma loss this would currently give 93.75 which gets rounded to 94.

Suggested fix either keep the code in necromancerspell.cs would probably work. Alternatively I changed the formula in titles.cs to a += and took the code out of necromancerspell.cs about increasedkarmaloss and tested it and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant