Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seed of Renewal in loot #5022

Open
evilmaza242 opened this issue Oct 4, 2022 · 3 comments
Open

Add Seed of Renewal in loot #5022

evilmaza242 opened this issue Oct 4, 2022 · 3 comments

Comments

@evilmaza242
Copy link

https://www.uoguide.com/Seed_of_Renewal

@Lexshmyr
Copy link

Lexshmyr commented Oct 5, 2022

So the link on uoguide states that a Seed of Renewal is a resource dropped as loot from Cavern of Discarded creatures and from the plant seed harvesting action.

Both of these are covered in the pub58 ServUO code.

It drops as one of 10 items at Cavern of the Discarded creatures. Taken from ./Scripts/Services/Plants/ReproductionGump.cs:

m_IngredientTable.Add(new IngredientDropEntry(typeof(BaseCreature), false, "Cavern of the Discarded", 0.05,
 typeof(DelicateScales), typeof(ArcanicRuneStone), typeof(PowderedIron), typeof(EssenceBalance), 
 typeof(CrushedGlass), typeof(CrystallineBlackrock), typeof(ElvenFletching), typeof(CrystalShards), 
 typeof(Lodestone), typeof(AbyssalCloth), typeof(SeedOfRenewal)));

Any loot drop from Cavern of the Discarded creatures is about a 1 in 20 chance, so any individual items is about 1 in 200 chance.

The gardening system, when harvesting seeds from a mature plant is a 1 in 20 chance. Taken from ./Scripts/Services/LootGeneration/Imbuing/ResourceDrops.cs:

 if (Utility.RandomDouble() < 0.05)
 {
    Item Rseed = new SeedOfRenewal();
    if (from.PlaceInBackpack(Rseed))
    {
       system.AvailableSeeds--;
       m_Plant.LabelTo(from, 1053063); // You gather seeds from the plant.
    }
    else
    {
       Rseed.Delete();
       m_Plant.LabelTo(from, 1053062); // You attempt to gather as many seeds as you can hold, but your backpack is full.
    }

I have confirmed that the Cavern of the Discarded loot drops work in game.
I have not confirmed that the gardening system works, but only researched the code to see it is there. Probably the best test would be to setup the Raised Garden Bed and harvest only seeds at full maturity. The theoretical number of seeds would average 3-4 from a fully mature Raised Garden Bed with plants that give seeds as a resource when everything is harvested. The largest Raised Garden Bed give 9 plant spots and fully mature plants give 8 resources.
9 plants x 8 resources = 72 resources * .05 (chance or 1 in 20) = 3.6 Seeds of Renewal over a 17 day period.

Either this is an issue for other than ServUO pub58 or it needs more information to be considered a bug.

@evilmaza242
Copy link
Author

Ty but this drop rate i think to low ... maybe for osi its not problem where people use 10 chars for afk farm and 50000 hp boss die super fast )

@Lexshmyr
Copy link

Lexshmyr commented Oct 8, 2022

Both of the snippets referenced above have the value ".05" which is the 5% or 1 in 20 chance of a drop. It can be adjusted from 1% (.01) through 100% (1.0) to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants