Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[p58] Player character turns toward item being lifted. #5035

Open
wtfuzzy opened this issue Dec 10, 2022 · 0 comments
Open

[p58] Player character turns toward item being lifted. #5035

wtfuzzy opened this issue Dec 10, 2022 · 0 comments

Comments

@wtfuzzy
Copy link

wtfuzzy commented Dec 10, 2022

p58 introduced a behavior I've not seen in the past (and doesn't exist on OSI) wherein lifting an item from the ground (or from a container on the ground) causes the player character to be turned in the direction of the item (or container). If this feature is deliberate, I suspect it was meant to apply only to NPCs.

The relevant code is in Server/Mobile.cs, HandleLift, around line 4413:

                if (!m_Moving)
                {
                    Direction = GetDirectionTo(src);
                }

Adding && !m_Player to the conditional appears to resolve the issue, but I don't know if there are any side effects, nor if this code should actually exist at all.

                if (!m_Moving && !m_Player)
                {
                    Direction = GetDirectionTo(src);
                }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant