Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-utils bootstrapForm with input groups doesn't display error correctly #682

Closed
georgehemmings opened this issue Aug 5, 2019 · 2 comments

Comments

@georgehemmings
Copy link

I've found an issue when using bootstrapForm to show input errors next to input groups when using Bootstrap 4.

To demo the issue, I've forked the Validation project and changed the textbox on Full Name to be a input group with a textbox and a button. See this commit georgehemmings/Validation@d93068b

If you browse to https://localhost:44310/client-jquery/contacts/ and click the Add Contact button you'll see that the input group is broken up visually as the error message is appended after the text box when it should be placed after the input group.

image

image

@mythz
Copy link
Member

mythz commented Aug 5, 2019

There was never any support for input groups which aren't properly supported by Bootstrap so this is more a feature request than an issue but I've added support for it in ss-utils.js in this commit which will insert the validation message at the end of the input group although Bootstrap's still doesn't support displaying an invalid-feedback in an input group properly.

This change is available from the latest v5.5.1 that's now available on MyGet.

@mythz mythz closed this as completed Aug 5, 2019
@georgehemmings
Copy link
Author

Cheers. Looks good to me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants