Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native cstr literals #93

Closed
asomers opened this issue Apr 28, 2024 · 0 comments · Fixed by #99
Closed

Use native cstr literals #93

asomers opened this issue Apr 28, 2024 · 0 comments · Fixed by #99

Comments

@asomers
Copy link
Contributor

asomers commented Apr 28, 2024

Rust 1.77.0 introduces cstr literals. We should use that feature and remove the cstr crate.
https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html#c-string-literals
We need to make sure that this won't violate any MSRV guarantees, however.
asomers added a commit to asomers/fuse3 that referenced this issue May 25, 2024
@asomers
Use native CStr literals
eb3da78 
This eliminates the cstr and syn-1 crates, and raises MSRV to 1.77.0

Fixes Sherlock-Holo#93
@asomers asomers mentioned this issue May 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use native CStr literals asomers/fuse3
1 participant
@asomers